Page MenuHomePhabricator

Institution term is not checked for illegal characters (slash, in particular)
Closed, DeclinedPublic

Description

Institution titles are not supposed to include slashes, because slashes are delimiters between course pages and institution pages and some of the code uses the number of slashes to determine how pages are handled and what their titles are.

However, slashes can enter the title of an institution page if entered in the 'institution' field. This results in a database error, specified below.

Slashes should replaced for dashes automatically as suggested for the same issue concerning course names.

error documentation: (the error occurs after filling in the details on the course (next page), not immediately after the 'wrong' input.
Query:
INSERT INTO ep_courses (course_org_id,course_name,course_title,course_start,course_end,course_description,course_token,course_students,course_instructors,course_online_ambs,course_campus_ambs,course_field,course_level,course_term,course_lang,course_student_count,course_instructor_count,course_oa_count,course_ca_count,course_touched) VALUES ('','','Education Program:Great/Institution/Institute','20150115000000','20150715000000',' textextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttexttextextexttext','','a:0:{}','a:0:{}','a:0:{}','a:0:{}','','',NULL,'en','0','0','0','0','20150115121639')

Function: ORMRow::insert
Error: 1048 Column 'course_term' cannot be null ()

Backtrace:

#0 /vagrant/mediawiki/includes/db/Database.php(1203): DatabaseBase->reportQueryError()
#1 /vagrant/mediawiki/includes/db/Database.php(2048): DatabaseBase->query()
#2 /vagrant/mediawiki/includes/db/ORMRow.php(413): DatabaseBase->insert()
#3 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/RevisionedObject.php(225): ORMRow->insert()
#4 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/Course.php(138): EducationProgram\RevisionedObject->insert()
#5 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/RevisionedObject.php(139): EducationProgram\Course->insert()
#6 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/PageObject.php(73): EducationProgram\RevisionedObject->save()
#7 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/Course.php(363): EducationProgram\PageObject->save()
#8 /vagrant/mediawiki/extensions/EducationProgram/includes/rows/RevisionedObject.php(263): EducationProgram\Course->save()
#9 /vagrant/mediawiki/extensions/EducationProgram/includes/actions/EditAction.php(476): EducationProgram\RevisionedObject->revisionedSave()
#10 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(501): EducationProgram\EditAction->handleSubmission()
#11 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(424): HTMLForm->trySubmit()
#12 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(439): HTMLForm->tryAuthorizedSubmit()
#13 /vagrant/mediawiki/extensions/EducationProgram/includes/actions/EditAction.php(198): HTMLForm->show()
#14 /vagrant/mediawiki/extensions/EducationProgram/includes/actions/EditAction.php(64): EducationProgram\EditAction->showForm()
#15 /vagrant/mediawiki/extensions/EducationProgram/includes/actions/EditCourseAction.php(133): EducationProgram\EditAction->onView()
#16 /vagrant/mediawiki/includes/actions/FormlessAction.php(43): EducationProgram\EditCourseAction->onView()
#17 /vagrant/mediawiki/includes/MediaWiki.php(414): FormlessAction->show()
#18 /vagrant/mediawiki/includes/MediaWiki.php(282): MediaWiki->performAction()
#19 /vagrant/mediawiki/includes/MediaWiki.php(584): MediaWiki->performRequest()
#20 /vagrant/mediawiki/includes/MediaWiki.php(435): MediaWiki->main()
#21 /vagrant/mediawiki/index.php(46): MediaWiki->run()
#22 /var/www/w/index.php(5): include()
#23 {main}

Event Timeline

Sputniza raised the priority of this task from to Needs Triage.
Sputniza updated the task description. (Show Details)
Sputniza subscribed.
Reedy subscribed.

Extension is being removed and archived.