When rolling back edits that equate to no change a misleading failure message is displayed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Jan 15 2015, 12:54 PM

Description

For example when trying to rollback the 3 edits listed here https://en.wikipedia.org/w/index.php?title=Rachel_Riley&diff=642596311&oldid=642037500 which would actually not change the content of the article.

The message displayed is

Rollback failed
Cannot roll back edit to Rachel Riley by 195.195.24.21 (talk · block · contribs) because someone else has edited the page.
The last revision was by 195.195.24.21 (talk · contribs).

This should instead say something like "Cannot roll back edit to X by Y because the action would result in no page change"

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use more specific error message for no-change rollbacks	mediawiki/core	master	+7 -3

Customize query in gerrit

Related Objects

Duplicates Merged Here: T124793: Confusing rollback error message when a rollback doesn't cause a content change

Event Timeline

Addshore created this task.Jan 15 2015, 12:54 PM

Addshore raised the priority of this task from to Low.

Addshore updated the task description. (Show Details)

Addshore added a project: MediaWiki-General.

Addshore subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2015, 12:54 PM

matej_suchanek added a project: TestMe.Apr 2 2016, 8:57 AM

matej_suchanek merged a task: T124793: Confusing rollback error message when a rollback doesn't cause a content change.Feb 24 2017, 9:37 PM

matej_suchanek added subscribers: liangent, StudiesWorld.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptFeb 24 2017, 9:37 PM

matej_suchanek removed a project: TestMe.Feb 24 2017, 9:37 PM

Stryn subscribed.May 31 2018, 6:50 PM

Addshore unsubscribed.Jun 27 2023, 12:34 PM

Pppery claimed this task.Feb 16 2025, 7:38 PM

Pppery edited projects, added MediaWiki-Patrolling; removed MediaWiki-General.

Change #1119881 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Use more specific error message for no-change rollbacks

https://gerrit.wikimedia.org/r/1119881

gerritbot added a project: Patch-For-Review.Feb 16 2025, 7:50 PM

Change #1119881 merged by jenkins-bot:

[mediawiki/core@master] Use more specific error message for no-change rollbacks

https://gerrit.wikimedia.org/r/1119881

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2025, 12:30 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 21 2025, 1:00 PM

The new message says: because {{GENDER:$2|he|she|they}} made only dummy revisions.

Are "dummy revisions" the same as "null edits" or something different?

A "dummy revision" is https://www.mediawiki.org/wiki/Manual:Dummy_revision

In T86910#11396424, @Pppery wrote:

A "dummy revision" is https://www.mediawiki.org/wiki/Manual:Dummy_revision

Thanks. I followed up at https://www.mediawiki.org/wiki/Manual_talk:Dummy_revision#%22Null%22_vs_%22dummy%22

@Pppery I noted that there are two spaces between "[[:$1]]" and "by" in the new message.

In T86910#11397002, @Samoasambia wrote:

@Pppery I noted that there are two spaces between "[[:$1]]" and "by" in the new message.

I already fixed it, it will appear on translatewiki some time soon.

Izno subscribed.Nov 21 2025, 6:57 PM

Pppery closed this task as Resolved.Nov 26 2025, 4:44 AM

When rolling back edits that equate to no change a misleading failure message is displayedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

When rolling back edits that equate to no change a misleading failure message is displayed
Closed, ResolvedPublic
Actions