Page MenuHomePhabricator

Remove extra "Primary" field in review system
Closed, ResolvedPublic

Description

In the "Participation in Wikimedia projects" section, there are three sections: "Main Wiki Project", "Primary" and "Secondary".

I think there's a redundancy between "Main Wiki Project" and "Primary"? If so, please remove "Primary".

Event Timeline

Shouston_WMF raised the priority of this task from to Medium.
Shouston_WMF updated the task description. (Show Details)
Shouston_WMF subscribed.

It's actually just a quirk of the css formatting for the definition list, but yeah it's easily fixed by removing the "Primary:" label.

gerritbot subscribed.

Change 185389 had a related patch set uploaded (by Niharika29):
Fix formatting for the "Primary" field in the review system

https://gerrit.wikimedia.org/r/185389

Patch-For-Review

Hi Sati! Sorry, my fault. Fixed it now. It looks like: http://cl.ly/image/2v270a1L2616
Would you rather I remove "Primary" field completely and put the primary project in front of the "Main Wiki Projects"?

Niharika set Security to None.
Niharika moved this task from Backlog to Needs Review on the Wikimedia-Wikimania-Scholarships board.

Change 185389 merged by jenkins-bot:
Fix formatting for the "Primary" field in the review system

https://gerrit.wikimedia.org/r/185389

@NiharikaKohli Removing the "Primary" and just putting the primary project into the "Main Wiki Project" makes complete sense. Thanks for checking first!

@NiharikaKohli Actually, I just took a look in the review system, and it seems like the projects are coming into the "Primary" label. So might be easier to just change the "Primary" label to "Main Wiki Project" and remove the currently unused "Main Wiki Project" field.

Also, to make things clearer for the reviewers, the "Secondary" should change to "Secondary Wiki Project" for consistency.

Change 185961 had a related patch set uploaded (by Niharika29):
Remove "Main Wiki Projects" empty field from review view

https://gerrit.wikimedia.org/r/185961

Patch-For-Review

Change 185961 merged by jenkins-bot:
Remove "Main Wiki Projects" empty field from review view

https://gerrit.wikimedia.org/r/185961

bd808 moved this task from Needs Review to Done on the Wikimedia-Wikimania-Scholarships board.
bd808 moved this task from Done to Archive on the Wikimedia-Wikimania-Scholarships board.