Page MenuHomePhabricator

Scrolling issues in beta with new ReferencesDrawer
Closed, ResolvedPublic

Description

When a long reference drawer is scolled, the drawer closes. You can test this on Diana, Princess of Wales article on Beta Labs – I made the first reference really long.
http://en.m.wikipedia.beta.wmflabs.org/wiki/Diana,_Princess_of_Wales?mobileaction=beta

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to To Triage on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2015, 7:04 PM

On the example I can scroll on desktop so I assume this is only limited to touch devices?

gerritbot added a subscriber: gerritbot.

Change 178338 had a related patch set uploaded (by Jdlrobson):
Scrollable reference drawers

https://gerrit.wikimedia.org/r/178338

Patch-For-Review

@rmoen Could you test this situation against your current patchset in Gerrit and make sure it is addressed?

This has been a primary thought of my patch. And I have tested it on IOS 8 simulator and chrome. I will test further.

@Jdlrobson Correct. In desktop, if you focus the main body you can scroll the page. In Mobile, touches outside the drawer and scrolling beyond the drawer prevents body from scrolling.

Ping @rmoen let's either get this bug fix wrapped up today or abandon the patch and free it for a volunteer.

Change 178338 abandoned by Jdlrobson:
Scrollable reference drawer beta behavior

Reason:
Abandoning due to lack of activity. Please restore and repost a new patch if you want to continue to work on this.

https://gerrit.wikimedia.org/r/178338

Change 194716 had a related patch set uploaded (by Bmansurov):
Beta: Don't close ReferencesDrawer on scroll

https://gerrit.wikimedia.org/r/194716

bmansurov closed this task as Resolved.Mar 6 2015, 6:20 PM
bmansurov claimed this task.

Change 194716 merged by jenkins-bot:
Beta: Don't close ReferencesDrawer on scroll

https://gerrit.wikimedia.org/r/194716