Page MenuHomePhabricator

VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup
Closed, ResolvedPublic

Description

Since oojs-ui is already loaded in this context, the editor switcher (which has various visual issues in alpha) should be rebuilt using oojs-ui

Screen_Shot_2015-01-16_at_11.16.26_AM.png (168×206 px, 12 KB)

This work will be useful in consolidating how icons are built in MobileFrontend/VE

Bartosz, James is there a demo for this widget, is OO.ui.PopupToolGroup the right one?

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to 2015-16 Q4 on the Readers-Web-Backlog board.

You could use DropdownWidget or PopupButtonWidget – see https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr for examples. It depends exactly how you want it to behave.

gerritbot added a subscriber: gerritbot.

Change 188695 had a related patch set uploaded (by Bmansurov):
Create the editor switcher buttons using oojs-ui

https://gerrit.wikimedia.org/r/188695

Patch-For-Review

Change 188695 merged by jenkins-bot:
Create the editor switcher buttons using oojs-ui

https://gerrit.wikimedia.org/r/188695

phuedx added a subscriber: phuedx.