Page MenuHomePhabricator

No way to get to file page of audio file from a gallery
Open, NormalPublic

Description

E.g. https://commons.wikimedia.org/wiki/Commons:Wikimedia_Sverige/recent_uploads/2015_January#15_January_2015
(This is breaking attribution and violating licenses, which need to be fixed ASAP.)

Event Timeline

Tgr created this task.Jan 16 2015, 8:09 PM
Tgr raised the priority of this task from to High.
Tgr updated the task description. (Show Details)
Tgr added a project: TimedMediaHandler.
Tgr added a subscriber: Tgr.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 16 2015, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a comment.Jan 16 2015, 8:09 PM

Probably a regression, but no one seems sure.

Probably caused by https://gerrit.wikimedia.org/r/#/c/181810/2 (lack of message registration?)

This only applies for when the audio file is in a gallery, see https://commons.wikimedia.org/wiki/User:Josve05a/T87056

Tgr added a comment.Jan 16 2015, 8:21 PM
In T87056#982844, @Tgr wrote:

Probably caused by https://gerrit.wikimedia.org/r/#/c/181810/2 (lack of message registration?)

It does not seem related, TMH just uses an unusualy way of message registration, but the new message does get loaded.

Josve05a raised the priority of this task from High to Unbreak Now!.Jan 20 2015, 1:35 PM
Josve05a updated the task description. (Show Details)
Josve05a set Security to None.

CC'ing patch author of https://gerrit.wikimedia.org/r/#/c/181810/ (just in case it's related).

Similar/related tasks: T43762: File description page not accessible inside <gallery>, T33583: Video player doesn't include copyright/licensing information.

Not sure if this should be "Unbreak now" priority or just "high" either, leaving that to Multimedia team.

Tgr lowered the priority of this task from Unbreak Now! to High.Jan 20 2015, 9:21 PM

So far it does not seem this was broken - it is probably simply how TMH works. So if it was not a huge problem in the last three or so years, I don't think it is a critical issue if it stays the same way for a few more weeks. I suppose the menu button becomes invisible when the widget has little horizontal space; changing might be nontrivial for very small sizes, but for the size used by the gallery, there is more than enough place.

Gilles claimed this task.Jan 30 2015, 6:50 PM
Gilles moved this task from Untriaged to Next up on the Multimedia board.

I've found the logic and it's actually trying to cram everything it can in the available space, going left to right. Now I'll check if the "available space" calculation is correct.

Tgr added a comment.EditedJan 30 2015, 7:13 PM

I've found the logic and it's actually trying to cram everything it can in the available space, going left to right. Now I'll check if the "available space" calculation is correct.

The space after the play button is unreasonably large, so it should be easy to chip away there if not everything fits. (I wonder if maybe a progress indicator used to be there / is there for some clients? It would be the logical place but I don't see anything like that.

Tweaking the hardcoded width values doesn't help, there doesn't seem to be enough space. Plus, the CC icon takes priority, before the menu.

Gilles removed Gilles as the assignee of this task.Feb 11 2015, 12:58 PM
Gilles lowered the priority of this task from High to Normal.
Gilles moved this task from Next up to Prototyping on the Multimedia board.
Gilles added a subscriber: Gilles.
Gilles moved this task from Prototyping to Untriaged on the Multimedia board.Apr 6 2015, 9:21 AM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:24 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 6:24 PM