Page MenuHomePhabricator

'1 watcher(s)' as well as 'a member' in project edit logs
Closed, ResolvedPublic

Description

Event Timeline

Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis subscribed.
Aklapper claimed this task.

But how does that expose any problem?
"added 1 watcher(s)" isn't entirely incomprehensible and currently there is only English provided, hence no issues with language that have more than one plural.

it exposes '1 watcher(s)'.

MediaWiki solves this with a plural function.

Aklapper triaged this task as Lowest priority.
Aklapper set Security to None.

Ugh. https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
The specific string mentioned in the initial comment is not in that file, I guess it should.

Looks like they're using a pseudo-gettext (keyless) format, stored in PHP arrays. So they have all the limits of gettext, without any of the advantages?

Is "Phabricator lacks plural support" still true, or do they have some kind of plural support and they are just not using it?

@Krenair reported https://secure.phabricator.com/T7319 upstream, and the report is resolved. I still don't know whether Phabricator lacks support for plurals, or whether such support still needs to be implemented in some strings.

They don't lack support for it, it just wasn't being used for this message.

Qgil renamed this task from Phabricator lacks plural support to '1 watcher(s)' as well as 'a member' in project edit logs.Feb 19 2015, 4:51 PM
Qgil updated the task description. (Show Details)