Page MenuHomePhabricator

JavaScript error in IE 8 due to {{~null~}}
Closed, ResolvedPublic

Description

This is compiled by Handlebars into JS source code that includes helpers.null and depth0.null. IE 8 gives a syntax error, "Expected identifier", when Handlebars tries to compile this to a function.

I've put up a Handlebars patch to fix it upstream, but in the meantime we can also use {{~noop~}}, which I believe has the exact same effect, and may be more intuitive anyway.

This causes major user-facing problems, e.g. it can't render new topics at all.

Event Timeline

Mattflaschen-WMF raised the priority of this task from to High.
Mattflaschen-WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2015, 12:34 AM
gerritbot added a subscriber: gerritbot.

Change 185392 had a related patch set uploaded (by Mattflaschen):
Fix multiple major IE 8 issues

https://gerrit.wikimedia.org/r/185392

Patch-For-Review

Change 185392 merged by jenkins-bot:
Fix multiple major IE 8 issues

https://gerrit.wikimedia.org/r/185392

Mattflaschen-WMF closed this task as Resolved.Feb 25 2015, 10:28 PM
Mattflaschen-WMF claimed this task.