protect.py only unprotects pages because it cannot properly determine which protection types are valid
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sn1per
	Jan 18 2015, 2:29 AM

Description

Line 105 of protect.py should have self.protections.items() instead of self.protections, or else protection arguments are not passed to api call.

	Subject	Repo	Branch	Lines +/-
	Properly determine the valid protection types	pywikibot/core	master	+28 -30

Status	Assigned	Task
Resolved	Sn1per	T87155 Unit tests for protect.py
Resolved	Sn1per	T63312 protect.py should have different messages for protect/unprotect pages
Resolved	Sn1per	T87124 protect.py only unprotects pages because it cannot properly determine which protection types are valid

Sn1per raised the priority of this task from to High.

Sn1per updated the task description. (Show Details)

Sn1per added a project: Pywikibot.

Sn1per subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptJan 18 2015, 2:29 AM

Change 185661 had a related patch set uploaded (by Sn1per):
Properly determine the valid protection types

Change 185661 merged by jenkins-bot:
Properly determine the valid protection types

Hooray!