Page MenuHomePhabricator

Guiders can be positioned outside of page bounds
Open, Needs TriagePublic

Description

If the guider is attached to an element near the top (and presumably bottom, left, right, etc) of the page, it is positioned outside of bounds.

See this screenshot: F29544

Code:

tour.step( {                                                                                   
    name: 'close',                                                                             
    titlemsg: 'multimediaviewer-tour-close-title',                                             
    descriptionmsg: 'multimediaviewer-tour-close-description',                                 
    attachTo: '.mw-mmv-close',                                                                 
    position: 'right',                                                                      
    buttons: [ {                                                                               
        action: 'end'                                                                          
    } ]                                                                                        
} );

'rightTop' is doesn't work as the arrow/caret seems to have some sort of minimum distance, and the arrow/caret ends up pointing at the fullscreen button, which is inappropriate.

Event Timeline

Unicodesnowman raised the priority of this task from to Needs Triage.
Unicodesnowman updated the task description. (Show Details)
Unicodesnowman added a subscriber: Unicodesnowman.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2015, 10:23 AM
Deskana renamed this task from Guiders can be positioned outside of page bounds to VisualEditor.Aug 30 2018, 1:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2018, 1:30 PM
Deskana renamed this task from VisualEditor to Guiders can be positioned outside of page bounds.Aug 30 2018, 1:40 PM