Page MenuHomePhabricator

Closing mobile media viewer always scrolls to top on FF, IE
Closed, ResolvedPublic

Description

The previous scroll position is not restored. No console messages. The problem does not occur in Chromium or on the desktop site.

Event Timeline

tstarling raised the priority of this task from to Needs Triage.
tstarling updated the task description. (Show Details)
tstarling added a project: MediaViewer.
tstarling added a subscriber: tstarling.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

*.m.* uses the mobile viewer, a separate product.

tstarling renamed this task from Closing MMV always scrolls to top on *.m.wikipedia.org on FF, IE to Closing mobile media viewer always scrolls to top on FF, IE.Jan 19 2015, 2:44 AM

This might be a generic problem with overlay scrolling. The same might happens for the talk overlay. Can someone investigate and verify locally? We've done a bunch of refactoring so it's possible this is fixed in latest master.

Strange. What is Chrome doing differently (as it's not an issue there)?

For the desktop product, we save/restore the scroll position from JS.

We do on mobile too.. for some reason only applying in Chrome though.

gerritbot added a subscriber: gerritbot.

Change 188681 had a related patch set uploaded (by Bmansurov):
Restore document scroll position after closing the overlay

https://gerrit.wikimedia.org/r/188681

Patch-For-Review

Change 188681 merged by jenkins-bot:
Restore document scroll position after closing the overlay

https://gerrit.wikimedia.org/r/188681