They currently use this.$( '.selector' ).on instead
The View class has an events property that these classes should use instead to bind their events.
Someone needs to separate the click events into event handlers e.g. onThisAction
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Overlay, Panel, Drawer made to use View##events | mediawiki/extensions/MobileFrontend | master | +117 -80 |
Related Objects
Related Objects
Event Timeline
Comment Actions
@Jdlrobson, if I get this right, we have to change the jquery event handlers to handlers defined by the native MobileFrontend OO library?
Comment Actions
@Sumit EditorOverlayBase is a good example. Take a look at events and onClickSubmit function. Basically we don't want to bind events in the postRender function for these classes.
Comment Actions
Change 188673 had a related patch set uploaded (by Sumit):
Overlay,Panel,Drawer made to use View##events
Comment Actions
@Sumit thanks for the patch! :D, i've left a buncha comments, this are very basic views so we have to make sure they extend their parents events, and check child classes and if they use events map, extend from this ones we are modifying.
I'm a bit scared we are going to miss something and break stuff subtly for millions of people! we gotta be careful ;)
Thanks again!