Create button abstraction
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 20 2015, 7:05 PM

Description

Wherever we use mw-ui-button we should replace this with a class which works in a similar way to Icon.js
This will help us transition to OOJS UI more easily.

Note where a button is also an Icon we should use a ButtonIcon abstraction which merges both concepts.

Details

	Subject	Repo	Branch	Lines +/-
	Add button abstraction	mediawiki/extensions/MobileFrontend	master	+59 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Declined	None	T144571 Mobile Media Viewer violates user settings
Open	Jdlrobson	T65504 Consolidate code for MediaViewer across desktop and mobile
Declined	None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Duplicate	Jdlrobson	T66316 [EPIC] Move Nearby code to more suitable extension
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Declined	None	T96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
Resolved	• bmansurov	T87254 Create button abstraction

Event Timeline

Jdlrobson created this task.Jan 20 2015, 7:05 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 7:06 PM

Ricordisamoa subscribed.Feb 19 2015, 6:18 PM

Why not directly transition to OOJS UI instead of this intermediate step?

We need to be using more of OOJS UI library before migrating over to it imo, it's not fair on our users to have an increased payload with duplicate infrastructure. With an abstraction this makes it a lot easier. Currently it should be very trivial to migrate over too oojs ui for icons for example. I would suggest:

Adding abstractions everywhere
In alpha/beta use OOJS ui for these abstractions
When all abstractions have been ported to OOJS ui migrate to stable, taking care not to break display for cached pages and avoid/perform cache flushes.