Page MenuHomePhabricator
Create Task
Maniphest T87265

"Read more" link is appearing even if the last line if the description of the image fits in the visible area
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open VisualEditor for a page
2.Now go to Insert>Media
3.Search for the keyword gtg
4.Select the image "Peinture Gaud GTG"

Observed Result:
Observe that the last line of the description ends just before the "Read More" link and there is no need for "Read More" in this case

Screen_Shot_2015-01-20_at_12.16.38_PM.png (406×904 px, 436 KB)

Details

SubjectRepoBranchLines +/-
Add a threshold to 'read more' calculation in media dialog infomediawiki/extensions/VisualEditormaster+30 -9
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 20 2015, 8:26 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 8:26 PM
Ryasmeen assigned this task to Mooeypoo.Jan 20 2015, 8:27 PM
Ryasmeen set Security to None.
Jdforrester-WMF triaged this task as Medium priority.Jan 20 2015, 8:56 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Mooeypoo added a comment.Feb 26 2015, 2:05 AM

I can't manage to reproduce this ever since the last update of the image info panel. Can you verify?

Mooeypoo added a comment.Feb 26 2015, 2:06 AM

Ignore that, I just found it. Investigating now.

gerritbot subscribed.Feb 26 2015, 11:41 PM

Change 193286 had a related patch set uploaded (by Mooeypoo):
Add a threshold to 'read more' calculation in media dialog info

https://gerrit.wikimedia.org/r/193286

gerritbot added a project: Patch-For-Review.Feb 26 2015, 11:41 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Media.Feb 28 2015, 1:05 AM
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Mar 4 2015, 7:13 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-04_(1.25wmf20); removed Patch-For-Review.
gerritbot added a comment.Mar 4 2015, 7:15 PM

Change 193286 merged by jenkins-bot:
Add a threshold to 'read more' calculation in media dialog info

https://gerrit.wikimedia.org/r/193286

Mooeypoo mentioned this in rEVED06f29f343ac8: Add a threshold to 'read more' calculation in media dialog info.Mar 4 2015, 7:15 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 5 2015, 1:43 AM
Ryasmeen added a project: Verified-in-Phase0.Mar 5 2015, 10:58 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM
Jdforrester-WMF edited a custom field.Mar 9 2015, 6:11 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:15 PM
Ryasmeen added a project: Verified-in-Phase2.Mar 12 2015, 9:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL