Page MenuHomePhabricator

DOM nodes with multiple typeof values
Open, MediumPublic

Description

In some cases, Parsoid seems to be adding both mw:ExpandedAttrs and mw:Transclusion type to dom nodes. This really doesn't make that much sense. mw:Transclusion is a stronger assertion about the node than a mw:ExpandedAttrs and should override it. This matters because clients like that don't yet support mw:ExpandedAttrs will refuse to make such nodes editable even though mw:Transclusion nodes are editable.

This can happen because ext.core.AttributeExpander doesn't check for the proper type. Or, it could happen when template ranges are merged / expanded during template wrapping.

So, worth auditing code and fixing it.

Event Timeline

ssastry raised the priority of this task from to Medium.
ssastry updated the task description. (Show Details)
ssastry added a project: Parsoid.
ssastry added subscribers: ssastry, Catrope.
ssastry renamed this task from DOM nodes with multiple typeof values to Technical Debt: DOM nodes with multiple typeof values.Jun 2 2015, 8:30 PM
ssastry set Security to None.
ssastry moved this task from In Progress to Needs Triage on the Parsoid board.
Arlolra renamed this task from Technical Debt: DOM nodes with multiple typeof values to DOM nodes with multiple typeof values.Jun 3 2015, 6:57 PM

Change 263802 had a related patch set uploaded (by Arlolra):
WIP: DOM nodes with multiple typeof values

https://gerrit.wikimedia.org/r/263802

Change 263802 abandoned by Arlolra:
WIP: DOM nodes with multiple typeof values

Reason:
For now ... until I pick it up again.

https://gerrit.wikimedia.org/r/263802