Page MenuHomePhabricator
Create Task
Maniphest T87293

MobileWebUploads validation error
Closed, ResolvedPublic
Actions

Description

"Validation error against schema MobileWebUploads: Wrong type for property: isEditable null"

According to the schema we cannot send null [1].

[1] https://meta.wikimedia.org/wiki/Schema:MobileWebUploads

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Hygiene: Pass correct value for isEditable in Uploads schemaFlorianschmidtwelzowmediawiki/extensions/MobileFrontendmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

• bmansurov created this task.Jan 21 2015, 1:44 AM
• bmansurov raised the priority of this task from to Needs Triage.
• bmansurov updated the task description. (Show Details)
• bmansurov added a project: Mobile.
• bmansurov subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2015, 1:44 AM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived; removed: Mobile.Jan 21 2015, 7:41 AM
Jdlrobson set Security to None.
Florian claimed this task.Jan 26 2015, 2:13 AM
Florian subscribed.

Hmm, the used config var wgIsPageProbablyEditable [1] doesn't exist, should use Page.isEditable().

[1] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/35cde9e2978b709252a6f4afe1c50e3f97862e59/javascripts/loggingSchemas/SchemaMobileWebUploads.js#L32

gerritbot added a project: Patch-For-Review.Jan 26 2015, 2:19 AM
gerritbot subscribed.

Change 186740 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Pass correct value for isEditable in Uploads schema

https://gerrit.wikimedia.org/r/186740

Patch-For-Review

gerritbot added a comment.Jan 27 2015, 5:49 AM

Change 186740 merged by jenkins-bot:
Hygiene: Pass correct value for isEditable in Uploads schema

https://gerrit.wikimedia.org/r/186740

phuedx mentioned this in rEMFR28f5fc41d394: Hygiene: Pass correct value for isEditable in Uploads schema.Jan 27 2015, 5:49 AM
phuedx closed this task as Resolved.Jan 27 2015, 5:49 AM
phuedx subscribed.
Florian mentioned this in rMEXT99496f81b2a0: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:25 AM
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q3 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits