Page MenuHomePhabricator

[Story] Group statements within statement group by ranks
Open, NormalPublic

Event Timeline

Question: should it be grouped by normal, preferred or deprecated? or should it be grouped by the concept of "best" statements?

How would grouping by best statement look like?

I'd say we would have three or two paragraphs. So, if we have statements of all ranks on a property, it would look like this:

Statements
preferred

Stale statements
normal

Wrong statements
deprecated

If we only have preferred and deprecated, it's:

Statements
preferred

Wrong statements
deprecated

And if we only have normal and deprecated, it's also:

Statements
normal

Wrong statements
deprecated

And finally, with preferred and normal statements, it looks like this:
Statements
preferred

Stale statements
normal

We need all 3 sections for drag and drop at least when editing. We probably don't want to show the sections that are not in use when not editing to reduce page clutter.
Let's please not use wrong/stale.

We use the concept of best statements everywhere except for editing. I can live with not using it for editing an entity, but I think we have to use it for displaying an entity. What people see in their client wikis should match what they see on the repo. In client wikis, best statements are used, no matter if they are normal or preferred. On the repo, there should be a section showing the statements that are used in clients, and the name of the section should not be different on different entities. Otherwise, it will confuse people, and for no good reason.

As for the captions, I don't really care about them. ›Wrong‹ should probably be ›Deprecated‹, since we already use that. ›Stale‹ could be ›Other‹ or ›More‹ or something like that.

Bene added a subscriber: Bene.Jul 29 2015, 1:19 PM
thiemowmde renamed this task from Group statements within statement group by ranks to [Task] Group statements within statement group by ranks.
thiemowmde added a project: patch-welcome.
thiemowmde set Security to None.
aude added a subscriber: aude.Oct 8 2015, 10:16 PM
This comment was removed by aude.
aude renamed this task from [Task] Group statements within statement group by ranks to [Story] Group statements within statement group by ranks.
aude added a comment.Oct 8 2015, 10:20 PM

related and possibly overlapping, I propose T115054 as a simple, short term solution to base sorting on ranks. (no grouping, just put preferred things at the top within a statement group and deprecated thing at the bottom)