Page MenuHomePhabricator

Math extension unit tests should not attempt to connect to wmflabs.org
Closed, ResolvedPublic

Description

Current master is failing, presumably because the wmflabs installation of Mathoid is either no longer compatible or down.

https://integration.wikimedia.org/ci/job/mwext-Math-testextension-zend/65/console

The unit tests should not be connecting to wmflabs.org (see also T87390).

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: Math.
Krinkle subscribed.
Krinkle set Security to None.
gerritbot subscribed.

Change 186581 had a related patch set uploaded (by Physikerwelt):
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/186581

Patch-For-Review

Physikerwelt changed the task status from Open to Stalled.Feb 7 2015, 8:28 PM
Physikerwelt triaged this task as High priority.

I have set up something like monitoring for mathoid... a simple script that restarts mathoid if it fails.
Thus we do not hurry too much with the code review...

... mh in the log there is a 502 (bad gateway) error.. which indicates that the problem might be related to the proxy and not mathoid itself
see
https://integration.wikimedia.org/ci/job/mwext-Math-testextension-zend/112/console
the system resource usage does not look too bad
https://tools.wmflabs.org/nagf/?project=math#h_mathoid2

Change 189355 had a related patch set uploaded (by Physikerwelt):
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/189355

Patch-For-Review

Change 189355 merged by jenkins-bot:
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/189355

@Aklapper How can we ensure that this change is chained for being reviewed at some point in time, even though it's not top priority.

@Physikerwelt: What is "this change"? https://gerrit.wikimedia.org/r/186581/ ? How is that one related to https://gerrit.wikimedia.org/r/189355 which you self-merged?
Generally I don't have a better answer than "pinging folks on Gerrit and IRC". Related: T78768.

The self merged change is on the debug branch. I maintaining this branch to
test if the proposed changes interact without problems.

@Aklapper: Is there a bug about developing a system that improves upon pinging people.
In academia reviewing is a well established process, I think there are some concept that could be adopted.
I think to establish a better process is a extremely important process, i.e. to keep volunteers motivated.
I'm not even sure if pinging works well for all WMF employees, even though I seldom have a chance to review WMF authored changes to the Math extension, because they are usually merged within a few minutes. I have to admit most of them are trivial re-factoring such as removing deprecated calls... see also http://www.hyrumwright.org/papers/icsm2013.pdf

Change 197238 had a related patch set uploaded (by Physikerwelt):
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/197238

Change 197238 merged by jenkins-bot:
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/197238

I updated to mathoid 0.2.6 (https://launchpad.net/~physikerwelt/+archive/ubuntu/mathoid)
I guess this will cause tests to fail again

.. mh the Blocked by tasks are supposed to be follow ups... not sure how to model that in phabricator

Change 186581 merged by jenkins-bot:
Move integration tests to a new special page

https://gerrit.wikimedia.org/r/186581