Page MenuHomePhabricator

Special:Book doesn't work without JS
Closed, InvalidPublic

Description

Currently Special:Book does not seem to work if no JavaScript is supported. If this is not supposed to be the case an error message should be shown.

This is especially problematic on mobile where we blacklist the running of JavaScript on many devices.

(see https://en.m.wikipedia.org/wiki/Special:Book)

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Collection.
Jdlrobson subscribed.

WORKSFORME

Steps I followed:
0) Disable JavaScript

  1. Special:Book
  2. Special:Random
  3. Click "add this page to the book"
  4. Special:Book

I. Observed: the title I added is listed correctly.

  1. Click "Download PDF"

II. Observed: the PDF was downloaded correctly.

I think there is a bunch of stuff going on here:
Specifically I was talking about how Special:Book has an update form with title and subtitle and several dropdowns that I cannot seem to use without JavaScript (the save book button takes me to a blank page)

This could be because I don't understand the UI or it is broken.
(There are also a bunch of other issues that will need capturing in other bugs - the submit button is disabled on mobile on that page, the panel at the top of the page for adding books currently doesn't load on mobile)

I'm talking to C Scott Wednesday IRL so hopefully I can clarify a few of these points.

I'm talking to C Scott Wednesday IRL so hopefully I can clarify a few of these points.

Did you manage?

@Jdlrobson: Can you answer the last question please?

We did chat, it seems the creation of a new book/changing the information about a book e.g. title is indeed broken without JavaScript (specifically https://en.wikipedia.org/wiki/Special:Book )
It uses ajax requests (POSTs to https://en.m.wikipedia.org/w/index.php when you update an input field) to save changes. So my original bug report is correct. There should be a save button to support non-JS use.

More generally we discussed about merging Extensions Gather and Collections if Gather proves to be a success since the features in Gather and Collection overlap in many ways.

ovasileva triaged this task as Medium priority.Sep 6 2017, 3:10 PM

This is especially problematic on mobile where we blacklist the running of JavaScript on many devices.

Since the creating books feature is not exposed to the mobile site, is this still a concern?

Okay looks like this sort of works, it's just a terrible UI :)
I added a book via https://en.m.wikipedia.org/wiki/Villamediana_de_Iregua?useskin=vector
and then when visiting https://en.m.wikipedia.org/wiki/Special:Book where JS is disable I can download book.

The print to pdf option is disabled until there is a page in the book. This is not very clear but makes sense.
When clicking the print pdf, the automatic page refresh of course does not work, so the user needs to refresh the page manually to see the download link (which is bad UX but functional).

In summary, this works but the experience can be improved. Later in another task if necessary.