Page MenuHomePhabricator
Create Task
Maniphest T87434

Split entityViewInit into WikibaseRepo and WikibaseView part
Closed, ResolvedPublic
Actions

Description

Most of the file should stay in WikibaseRepo:

  • triggerAnonymousEditWarning
  • Reference to mw.config (wbRepo, wbEntity, wbUserSpecifiedLanguages, wbCopyright, wbUserIsBlocked, wbUserCanEdit)
  • restrict, evaluateRestrictions
  • Watch handling
  • References to the following messages:
    • wikibase-anonymouseditwarning
    • wikibase-copyrighttooltip-acknowledge
    • wikibase-entity-*

WikibaseView should have a EntityViewFactory containing all other code in this file.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce wikibase.view.ViewFactorymediawiki/extensions/Wikibasemaster+301 -30
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT74907 [Task] move git repositories that are dependencies of wikidata to gerrit
 ResolvedTobi_WMDE_SWT103697 Add Phabricator project tag for Wikibase-DataModel-Services
 ResolvedAddshoreT45855 [Task] UI messages in repo, JS is in lib
 DeclinedNoneT75863 [Task] Split wikibase.git
 OpenNoneT108296 [Epic] Remove WikibaseLib
 ResolvedJeroenDeDauwT108286 [Task] Move Wikibase Lib code that belongs in DataModel Services to this new component
 ResolvedJeroenDeDauwT108963 [Task] Use services from WikibaseDataModelServices added in 1.1.0 release
 ResolvedAddshoreT75020 [Task] Move JS and PHP view code to separate repo
 Resolved• adrianheineT87434 Split entityViewInit into WikibaseRepo and WikibaseView part
 Duplicate• adrianheineT90720 Introduce wikibase.view.ViewFactory
 InvalidNoneT75887 [Task] Find a home for shared utilities like reporters, sites, etc.
 InvalidNoneT75875 Find a home for EntityChange and friends
 DeclinedNoneT76469 move formatters into own directory
 ResolvedthiemowmdeT76468 move parsers and validators into own directory
 ResolvedAddshoreT104187 Move services in DataModel to DataModel Services
 ResolvedJanZerebeckiT102629 Request Gerrit repository for WikibaseDataModelServices
 ResolvedJeroenDeDauwT93741 [RFC] Create place to put common Wikibase services
 ResolvedAddshoreT110344 Fix cohesion/CRP issue in Wikibase DataModel Services
 DeclinedNoneT108681 [RFC] Create a new Wikibase-Change-Services component
 InvalidNoneT108835 [RFC] Find a new home for Wikibase Lib / Reporting

Event Timeline

• adrianheine created this task.Jan 23 2015, 1:11 PM
• adrianheine raised the priority of this task from to Medium.
• adrianheine updated the task description. (Show Details)
• adrianheine added projects: Tracking-Neverending, Wikidata-Sprint-2015-01-08§, Wikidata, MediaWiki-extensions-Wikibase-Repo.
• adrianheine subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2015, 1:11 PM
• adrianheine removed projects: Wikidata-Sprint-2015-01-08§, Tracking-Neverending.Jan 23 2015, 1:11 PM
• adrianheine set Security to None.
• adrianheine updated the task description. (Show Details)Jan 23 2015, 1:15 PM
• adrianheine mentioned this in T87432: Identify messages that belong to WikibaseView.Jan 23 2015, 1:25 PM
• JohnLewis moved this task from incoming to ready to go on the Wikidata board.Jan 23 2015, 6:09 PM
• adrianheine updated the task description. (Show Details)Jan 28 2015, 9:30 AM
• adrianheine claimed this task.Jan 29 2015, 12:17 PM
• adrianheine added a project: § Wikidata-Sprint-2015-01-21.
• adrianheine moved this task from Backlog to Doing on the § Wikidata-Sprint-2015-01-21 board.
• adrianheine raised the priority of this task from Medium to High.Feb 3 2015, 12:59 PM
• adrianheine moved this task from Doing to Review on the § Wikidata-Sprint-2015-01-21 board.
gerritbot added a project: Patch-For-Review.Feb 3 2015, 1:02 PM
gerritbot subscribed.

Change 188357 had a related patch set uploaded (by Adrian Lang):
Introduce wikibase.view.ViewFactory

https://gerrit.wikimedia.org/r/188357

Patch-For-Review

Lydia_Pintscher added a project: § Wikidata-Sprint-2015-02-03.Feb 3 2015, 2:37 PM
Lydia_Pintscher subscribed.
Lydia_Pintscher moved this task from Backlog to Review on the § Wikidata-Sprint-2015-02-03 board.Feb 3 2015, 2:43 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-02-25.Feb 25 2015, 2:54 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-02-25 board.
Tobi_WMDE_SW moved this task from Review to Doing on the § Wikidata-Sprint-2015-02-25 board.Feb 25 2015, 2:57 PM
Tobi_WMDE_SW merged a task: T90720: Introduce wikibase.view.ViewFactory.Feb 26 2015, 4:08 PM
Tobi_WMDE_SW subscribed.
Tobi_WMDE_SW mentioned this in T90720: Introduce wikibase.view.ViewFactory.Feb 26 2015, 4:11 PM
Lydia_Pintscher moved this task from Doing to Review on the § Wikidata-Sprint-2015-02-25 board.Mar 11 2015, 12:25 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-11.Mar 11 2015, 12:26 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-11 board.
gerritbot added a comment.Mar 12 2015, 6:30 PM

Change 188357 merged by jenkins-bot:
Introduce wikibase.view.ViewFactory

https://gerrit.wikimedia.org/r/188357

Diffusion mentioned this in rMEXTcd6ed4598e22: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 12 2015, 6:30 PM
• adrianheine mentioned this in rEWBAff635e30d1a9: Introduce wikibase.view.ViewFactory.Mar 12 2015, 6:30 PM
Tobi_WMDE_SW closed this task as Resolved.Mar 13 2015, 11:27 AM
Tobi_WMDE_SW moved this task from Review to Done on the § Wikidata-Sprint-2015-03-11 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits