Page MenuHomePhabricator
Create Task
Maniphest T87446

Get JQuery error "a is undefined" running browser tests locally for Firefox
Closed, ResolvedPublic
Actions

Description

Attempting to run any browser tests locally fails for both VisualEditor and Echo (at least). Error reported is "a is undefined". This seems to be a jquery issue. Googling for it suggests that it could affect actual users and not only automated tests. Full stack trace is:

a is undefined (Selenium::WebDriver::Error::JavascriptError)

[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:26:in `F'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:39:in `Eb'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:50:in `T'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:60:in `Db'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:61:in `dc'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:61:in `anonymous/</<'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:14:in `anonymous/<'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit line 68 > Function:14:in `anonymous'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Bullets_VisualEditor_Test?vehidebetadialog=true&veaction=edit:68:in `handleEvaluateEvent'

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BrowserTest] remove old hack and fix "a is undefined" bugmediawiki/extensions/VisualEditormaster+1 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Cmcmahon created this task.Jan 23 2015, 6:46 PM
• Cmcmahon raised the priority of this task from to Needs Triage.
• Cmcmahon updated the task description. (Show Details)
• Cmcmahon added a project: VisualEditor-ContentEditable.
• Cmcmahon subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 23 2015, 6:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Cmcmahon updated the task description. (Show Details)Jan 23 2015, 7:55 PM
• Cmcmahon added a project: Notifications (Echo).
• Cmcmahon set Security to None.
• Cmcmahon added a comment.Jan 23 2015, 7:59 PM

Here is the stack track from trying to run an Echo test:

a is undefined (Selenium::WebDriver::Error::JavascriptError)

[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:20:in `P'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:29:in `ma'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:29:in `na'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:29:in `anonymous/</<'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:15:in `anonymous/<'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin line 68 > Function:15:in `anonymous'
[remote server] http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin:68:in `handleEvaluateEvent'
Jdforrester-WMF triaged this task as High priority.Jan 23 2015, 7:59 PM
Jdforrester-WMF added projects: JavaScript, MediaWiki-General.
Jdforrester-WMF subscribed.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Krenair added subscribers: Krinkle, Krenair.Jan 24 2015, 1:02 AM
• Cmcmahon raised the priority of this task from High to Unbreak Now!.Jan 29 2015, 6:17 PM

Made highest priority, this is preventing important work.

Jdforrester-WMF edited projects, added Release-Engineering-Team; removed VisualEditor 2014/15 Q3 blockers, VisualEditor-ContentEditable.Jan 29 2015, 6:19 PM
• Gilles subscribed.Jan 29 2015, 6:36 PM
Krinkle added a comment.Jan 29 2015, 6:58 PM

Please provide a reduced (browser) test case that triggers this error.

• Cmcmahon added a comment.Jan 29 2015, 7:04 PM

Literally every browser test in every repo that I run locally produces this error in Firefox.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jan 29 2015, 8:10 PM
• Cmcmahon added a comment.Jan 30 2015, 8:46 PM

It looks like:

And I click in the editable part # features/step_definitions/shared_steps.rb:6

a is undefined (Selenium::WebDriver::Error::JavascriptError)
gerritbot added a project: Patch-For-Review.Jan 30 2015, 10:56 PM
gerritbot subscribed.

Change 187829 had a related patch set uploaded (by Catrope):
[BrowserTest] remove old hack and fix "a is undefined" bug

https://gerrit.wikimedia.org/r/187829

Patch-For-Review

gerritbot added a comment.Jan 30 2015, 11:16 PM

Change 187829 merged by jenkins-bot:
[BrowserTest] remove old hack and fix "a is undefined" bug

https://gerrit.wikimedia.org/r/187829

Catrope mentioned this in rEVEDee79759d5f32: [BrowserTest] remove old hack and fix "a is undefined" bug.Jan 30 2015, 11:16 PM
Jdforrester-WMF added a comment.Jan 31 2015, 12:48 AM

Is this now fixed?

Ryasmeen subscribed.Jan 31 2015, 12:49 AM

functionally yes.

Jdforrester-WMF closed this task as Resolved.Jan 31 2015, 12:50 AM
Jdforrester-WMF assigned this task to • Cmcmahon.
Jdforrester-WMF removed a project: Patch-For-Review.
• Cmcmahon added a comment.Feb 2 2015, 2:44 PM

It's not exactly fixed.

• Cmcmahon added a comment.Feb 2 2015, 2:48 PM

It's not exactly fixed. Elena discovered that by not firing an explicit javascript 'onfocus' event, the error doesn't show up.

That doesn't mean that the error is not still present. Googling "a is undefined" seems to indicate that the cause is calling for the property of of some object when that object is undefined or otherwise not correct.

• Cmcmahon reopened this task as Open.Feb 4 2015, 5:13 PM
• Cmcmahon lowered the priority of this task from Unbreak Now! to High.
• Cmcmahon removed a project: VisualEditor.

I re-opened this, but I removed the VisualEditor project tag, because the problem is known to also affect Flow and MobileFrontend.

I have set the Priority to 'High' because I also discovered that this makes running browser tests on Vagrant impossible without going to lengths to install Chrome.

• Cmcmahon added a comment.Feb 4 2015, 5:27 PM

Here is a copy of the generic failure that is shared among all the repos:

a is undefined (Selenium::WebDriver::Error::JavascriptError)

[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:20:in `P'
[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:29:in `ma'
[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:29:in `na'
[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:29:in `anonymous/</<'
[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:15:in `anonymous/<'
[remote server] http://127.0.0.1/wiki/Special:UserLogin line 68 > Function:15:in `anonymous'
[remote server] http://127.0.0.1/wiki/Special:UserLogin:68:in `handleEvaluateEvent'
• Cmcmahon added a project: Scrum-of-Scrums.Feb 4 2015, 5:36 PM
• Cmcmahon added a comment.Feb 4 2015, 6:56 PM

Errors in the console when this happens:

Screen_Shot_2015-02-04_at_11.55.33_AM.png (874×2 px, 301 KB)

• Mattflaschen-WMF subscribed.Feb 4 2015, 8:24 PM

Note, the errors in that screenshot are all from inside the Firefox browser itself (and/or extensions). .jsm files can only be part of Firefox or extensions, not web site code. The same goes for chrome:// .

However, there could still be something in web site code starting the error chain somehow.

Has anyone tried running the tests in debug mode?

• Mattflaschen-WMF added a comment.Feb 4 2015, 8:36 PM

Also, the main errors in that screenshot appears to be two file not found errors in a WebDriver directory, one for xulstore.json.tmp and the other when trying to make a crashes directory.

So it looks like the whole webdriver-profile20150204-1183-1nanrhh directory is missing. It's not clear if this is part of the main chain or only comes into play when it tries to do error handling (e.g. the crashes directory).

• Cmcmahon closed this task as Resolved.Feb 5 2015, 5:32 PM

Removed the explicit onfocus event from the Login method in mediawiki_selenium shared code. Update mediawiki_selenium to version 0.4.2 or later if Firefox shows the "a is undefined" error.

greg moved this task from INBOX to Done on the Release-Engineering-Team board.Feb 5 2015, 7:09 PM
Milimetric moved this task from Scheduled to Done on the Scrum-of-Scrums board.Feb 25 2015, 6:56 PM
matmarex mentioned this in rMSELc0c0eb06733e: Remove explicit onfocus.Mar 3 2015, 7:44 PM
dduvall mentioned this in rMSEL21252403ae91: Remove explicit onfocus.Mar 3 2015, 7:44 PM
zeljkofilipin closed subtask T87873: Get JQuery error "a is undefined" running Echo browser tests locally for Firefox as Invalid.Jun 23 2015, 3:51 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 23 2015, 3:51 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 23 2015, 5:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits