Page MenuHomePhabricator
Create Task
Maniphest T87462

Don't use the preferences page to update preferences for each test. Only do that in the test dedicated to preferences
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Should cut the test time down a bit

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Set the preferences via the API when not testing the preferences pagemediawiki/extensions/UploadWizardmaster+59 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarkTraceur created this task.Jan 23 2015, 9:34 PM
MarkTraceur claimed this task.
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added a project: Multimedia.
MarkTraceur moved this task to Next up on the Multimedia board.
MarkTraceur subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2015, 9:34 PM
• Gilles subscribed.Feb 18 2015, 10:12 AM

Can you explain a little bit about how this would work? I'm not familiar with login redirects. We now have the need to set several preferences in different tests, this would be useful for 2 we currently have in review/

• Gilles added a project: Multimedia-Sprint-2015-02-18.Feb 18 2015, 10:12 AM
• Gilles removed MarkTraceur as the assignee of this task.Feb 18 2015, 10:21 AM
• Gilles set Security to None.
• Gilles edited a custom field.
Tgr subscribed.Feb 20 2015, 1:28 AM

Personally I would use the API, it's faster and probably more stable.

• Gilles claimed this task.Feb 24 2015, 6:33 PM
• Gilles renamed this task from Change browser tests for skip preference to use login redirects to Don't use the preferences page to update preferences for each test. Only do that in the test dedicated to preferences.Feb 24 2015, 7:42 PM
• Gilles added a project: UploadWizard.
gerritbot subscribed.Feb 24 2015, 7:46 PM

Change 192607 had a related patch set uploaded (by Gilles):
Set the preferences via the API when not testing the preferences page

https://gerrit.wikimedia.org/r/192607

Patch-For-Review

• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-02-18 board.Feb 24 2015, 7:46 PM
Aklapper added a project: Patch-For-Review.Feb 25 2015, 9:21 AM
• Gilles added a project: Multimedia-Sprint-2015-02-25.Feb 25 2015, 10:57 AM
• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-02-25 board.
gerritbot added a comment.Feb 25 2015, 8:25 PM

Change 192607 merged by jenkins-bot:
Set the preferences via the API when not testing the preferences page

https://gerrit.wikimedia.org/r/192607

MarkTraceur mentioned this in rEUWI897e5990b5a1: Set the preferences via the API when not testing the preferences page.Feb 25 2015, 8:25 PM
• Gilles moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-02-25 board.Feb 25 2015, 8:26 PM
• Gilles removed a project: Multimedia-Sprint-2015-02-18.Feb 25 2015, 8:54 PM
• Gilles closed this task as Resolved.Feb 26 2015, 4:27 PM
• Gilles added a parent task: T91651: Significantly increase UploadWizard test coverage.Mar 5 2015, 4:40 PM
Diffusion mentioned this in rMEXT57858c1999a0: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits