Page MenuHomePhabricator

Migrate as much as possible from network::constants from network.pp to hiera
Closed, DuplicatePublic

Description

There is stuff in network.pp like

https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/manifests/network.pp;7e42d3615e2f1372166d4eaf58779eaa5dd448dd$306

or
https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/manifests/network.pp;7e42d3615e2f1372166d4eaf58779eaa5dd448dd$260

that could be refactored and moved into hiera. Some stuff like all_networks and all_network_subnets are probably best left in network::constants though

Event Timeline

yuvipanda raised the priority of this task from to Normal.
yuvipanda updated the task description. (Show Details)
yuvipanda added subscribers: yuvipanda, Joe.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2015, 8:56 PM
mark added a subscriber: mark.
Dzahn added a subscriber: Dzahn.Mar 20 2015, 4:23 AM

Change 201882 had a related patch set uploaded (by Dzahn):
WIP - contint, move zuul_merger_hosts to hiera

https://gerrit.wikimedia.org/r/201882

akosiaris renamed this task from Kill network.pp to Migrate as much as possible from network::constants from network.pp to hiera.Aug 6 2015, 1:46 PM
akosiaris lowered the priority of this task from Normal to Low.
akosiaris updated the task description. (Show Details)
akosiaris set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 6 2015, 1:46 PM

Change 201882 merged by Dzahn:
contint: move zuul_merger_hosts to hiera, use in ferm

https://gerrit.wikimedia.org/r/201882

Dzahn added a comment.Sep 3 2015, 9:44 PM

10 lines less ...

Krenair added a subscriber: Krenair.

Reverse-duping this against T220894: Replacement of network::constant's special_hosts, anyone should feel free to reopen if they disagree

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptSat, Oct 5, 7:15 PM