Page MenuHomePhabricator
Create Task
Maniphest T87521

Convert JobRunner.php to PSR-3 logging and add levels
Closed, ResolvedPublic
Actions

Description

Make the jobRunner logging channel more friendly to Logstash by converting from wfDebugLog to direct use of the PSR-3 logger interface and categorizing the log messages as debug, info and error levels.

This will allow WMF production to add configuration that only sends warning level messages to logstash rather than collecting all messages which is a high volume data feed with low signal in the typical case.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
logstash: Exclude jobrunner debug messagesBryanDavisoperations/mediawiki-configmaster+1 -1
jobrunner: Change logging level for STARTING messagesBryanDavismediawiki/coremaster+1 -1
Convert JobRunner to PSR-3 loggerBryanDavismediawiki/coremaster+49 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

bd808 created this task.Jan 24 2015, 10:51 PM
bd808 raised the priority of this task from to Needs Triage.
bd808 updated the task description. (Show Details)
bd808 added a project: MediaWiki-Core-Team.
bd808 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2015, 10:51 PM
bd808 claimed this task.Jan 26 2015, 11:11 PM
bd808 moved this task from Backlog to In Dev/Progress on the MediaWiki-Core-Team board.
gerritbot added a project: Patch-For-Review.Jan 26 2015, 11:11 PM
gerritbot subscribed.

Change 186897 had a related patch set uploaded (by BryanDavis):
Convert JobRunner to PSR-3 logger

https://gerrit.wikimedia.org/r/186897

Patch-For-Review

bd808 triaged this task as Medium priority.Feb 2 2015, 8:51 PM
bd808 moved this task from In Dev/Progress to Needs Review/Feedback on the MediaWiki-Core-Team board.
bd808 set Security to None.
gerritbot added a comment.Feb 5 2015, 1:04 AM

Change 186897 merged by jenkins-bot:
Convert JobRunner to PSR-3 logger

https://gerrit.wikimedia.org/r/186897

bd808 mentioned this in rMW2eea1d5a42a4: Convert JobRunner to PSR-3 logger.Feb 5 2015, 1:04 AM
bd808 moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Feb 5 2015, 1:56 AM
bd808 added a comment.Feb 6 2015, 9:34 PM

Changes deployed but validation testing blocked by T88732: Decouple logging infrastructure failures from MediaWiki logging

bd808 mentioned this in T88732: Decouple logging infrastructure failures from MediaWiki logging.Feb 9 2015, 5:14 PM
bd808 moved this task from Done to Needs Review/Feedback on the MediaWiki-Core-Team board.Feb 14 2015, 2:58 AM
bd808 added a parent task: T92597: [DO NOT USE] MediaWiki debug logging (tracking) [superseded by #MediaWiki-Debug-Logger project].Mar 13 2015, 3:47 AM
Legoktm added a project: MediaWiki-Debug-Logger.Mar 13 2015, 5:37 PM
Legoktm added a subtask: T88732: Decouple logging infrastructure failures from MediaWiki logging.Mar 18 2015, 6:18 PM
bd808 edited projects, added: Reading-Infrastructure-Team-Old (Don't use); removed: MediaWiki-Core-Team.Apr 8 2015, 9:15 PM
bd808 closed subtask T88732: Decouple logging infrastructure failures from MediaWiki logging as Resolved.May 11 2015, 3:17 PM
gerritbot added a comment.May 11 2015, 4:38 PM

Change 210083 had a related patch set uploaded (by BryanDavis):
jobrunner: Change logging level for STARTING messages

https://gerrit.wikimedia.org/r/210083

gerritbot added a comment.May 11 2015, 4:51 PM

Change 210086 had a related patch set uploaded (by BryanDavis):
logstash: Exclude jobrunner debug messages

https://gerrit.wikimedia.org/r/210086

gerritbot added a comment.May 12 2015, 3:08 AM

Change 210083 merged by jenkins-bot:
jobrunner: Change logging level for STARTING messages

https://gerrit.wikimedia.org/r/210083

bd808 mentioned this in rMW9b8da198e071: jobrunner: Change logging level for STARTING messages.May 12 2015, 3:08 AM
gerritbot added a comment.May 19 2015, 11:19 PM

Change 210086 merged by jenkins-bot:
logstash: Exclude jobrunner debug messages

https://gerrit.wikimedia.org/r/210086

bd808 mentioned this in rOMWC51dec343c7af: logstash: Exclude jobrunner debug messages.May 19 2015, 11:20 PM
bd808 closed this task as Resolved.May 28 2015, 1:20 AM
bd808 moved this task from Backlog to Done on the Reading-Infrastructure-Team-Old (Don't use) board.Jul 6 2015, 4:01 PM
Danny_B removed a parent task: T92597: [DO NOT USE] MediaWiki debug logging (tracking) [superseded by #MediaWiki-Debug-Logger project].Feb 14 2016, 4:20 PM
hashar added a parent task: T92597: [DO NOT USE] MediaWiki debug logging (tracking) [superseded by #MediaWiki-Debug-Logger project].Feb 15 2016, 8:42 AM
Restricted Application added a project: User-bd808. · View Herald TranscriptJul 29 2016, 8:19 PM
• Phabricator_maintenance removed a parent task: T92597: [DO NOT USE] MediaWiki debug logging (tracking) [superseded by #MediaWiki-Debug-Logger project].Jul 29 2016, 8:19 PM
bd808 moved this task from To Do to Archive on the User-bd808 board.Sep 1 2016, 5:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits