Page MenuHomePhabricator

Change de.wikivoyage default setting of Floated table of contents
Closed, ResolvedPublic

Description

Floated table of contents ("Schwebendes Inhaltsverzeichnis") should be turned off for non-logged users.
See this discussion:
https://de.wikivoyage.org/wiki/Wikivoyage:Lounge/Archiv_2014-10-08#Schwebendes_Inhaltsverzeichnis_f.C3.BCr_nicht_angemeldete_Leser.3F

Event Timeline

FriedhelmW raised the priority of this task from to Medium.
FriedhelmW updated the task description. (Show Details)
FriedhelmW subscribed.
FriedhelmW renamed this task from Change de.wikivoyage default setting of float toc to Change de.wikivoyage default setting of Floated table of contents.Jan 25 2015, 5:15 PM
FriedhelmW updated the task description. (Show Details)
FriedhelmW set Security to None.

This might be
$wgDefaultUserOptions ['toc-floated'] = false;
(not sure).

I don't see a preference for this. Where is this coming from?

Oh. Looks like it's from TocTree extension which is enabled at wikivoyages only. Setting $wgDefaultUserOptions ['toc-floated'] = false; will change it for all users, not just non-logged in users.

Are you sure? Users can override this by their personal preferences.

Yes, users can override this by their personal preferences. I meant that by default it would be false by default for "all logged-in and non-logged in users". And from what I understand, that's not exactly what this task requests for according to the description.

Is there a test wiki on which we could check this?

After reading again, I assume existing user accounts will not be affected. Newly created accounts will default to no floated TOC but can override. This is intended and the task's title and description do not say something different. So please go ahead and set

$wgDefaultUserOptions ['toc-floated'] = false;

Since this has been "floating" here since August, I think it may be helpful as a motivation to translate the gist of the German discussion:

This creates display problems for non-logged on users, such as a headline being cut off. According to FriedhelmW, it affects all browsers that support CSS on all hardware.

All participants agree that it should get fixed.

Thank you for translating.
Here is the most prominent problem with floated TOC: The heading "Hintergrund" is cut off.

DE-VOY-ANON.png (768×1 px, 299 KB)

After reading again, I assume existing user accounts will not be affected. Newly created accounts will default to no floated TOC but can override.

Existing accounts will be affected unless they had overridden their preference. I just tested this locally. Newly created accounts will default to no floated TOC and will have the option to override it.

Here is the most prominent problem with floated TOC: The heading "Hintergrund" is cut off.

Shouldn't we do this for other languages as well then?

Shouldn't we do this for other languages as well then?

Probably not. Most other wikivoyages use the navigation bar at the top instead of the regular TOC.

gerritbot subscribed.

Change 187408 had a related patch set uploaded (by Glaisher):
Set $wmgUseFloatedToc to false at dewiki

https://gerrit.wikimedia.org/r/187408

Patch-For-Review

Change 187408 merged by jenkins-bot:
Set $wmgUseFloatedToc to false at dewikivoyage

https://gerrit.wikimedia.org/r/187408

Glaisher claimed this task.