Both for alignment and spacing purposes, all fields should be about 2.5em high (32px @ 0.875em). This includes things like text inputs, buttons, dropdowns and more complex widgets like the dimensions widget.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| demo: Add horizontal alignment test | oojs/ui | master | +85 -1 | |
| Add missing ButtonInputWidget.less and corresponding mixin | oojs/ui | master | +16 -0 |
Related Objects
Related Objects
Event Timeline
Comment Actions
- I'm not entirely convinced that this should always be this way (buttons can be a bit higher than text inputs perfectly fine for me, if they're aligned correctly; checkboxes and radios are different size too). But it should probably be true for all inputs and dropdowns at least.
- Which theme(s) need(s) changes?
Comment Actions
Change 189360 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Add horizontal alignment test to demo
Comment Actions
Change 190574 had a related patch set uploaded (by Bartosz Dziewoński):
Add missing ButtonInputWidget.less and corresponding mixin
Comment Actions
PHP:
PHP:
Here's how the demo looks with the two patches above.
Assuming we want to match the size in both themes, do we want to make the dropdowns smaller or the textboxes bigger?
Apex theme:
JS:
PHP:
MediaWiki theme:
JS:
PHP:
Comment Actions
Change 190574 merged by jenkins-bot:
Add missing ButtonInputWidget.less and corresponding mixin
Comment Actions
I haven't done anything about the heights of things, by the way. (Not sure if I should.)