Page MenuHomePhabricator

AndroidXmlFFS output should escape strings starting with "@"
Closed, ResolvedPublic

Description

Output of a string containing "@" in the middle in English but "@" at the start in Korean broke the Android app build: https://phabricator.wikimedia.org/T87628?workflow=create

Event Timeline

brion created this task.Jan 27 2015, 12:50 AM
brion raised the priority of this task from to Needs Triage.
brion updated the task description. (Show Details)
brion added subscribers: brion, Aklapper.
gerritbot added a subscriber: gerritbot.

Change 186932 had a related patch set uploaded (by BearND):
Fix build/translations

https://gerrit.wikimedia.org/r/186932

Patch-For-Review

bearND added a subscriber: bearND.Jan 27 2015, 7:31 AM

Linked ^ patch to the wrong bug number. The patch I submitted was just to fix the Android app build.

brion set Security to None.

Change 186995 had a related patch set uploaded (by Brion VIBBER):
Escape '@' sign at beginning of strings to avoid compilation breakage.

https://gerrit.wikimedia.org/r/186995

Patch-For-Review

Nikerabbit renamed this task from Android FFS output should escape strings containing initial "@" char to AndroidXmlFFS output should escape strings starting with "@".Jan 28 2015, 5:51 AM
Nikerabbit assigned this task to brion.
Nikerabbit triaged this task as High priority.

Change 186995 merged by jenkins-bot:
Escape '@' sign at beginning of strings to avoid compilation breakage.

https://gerrit.wikimedia.org/r/186995

brion closed this task as Resolved.Jan 28 2015, 11:08 PM

Ok, the quick fix and the fix to Translate are now merged, so this should be safe for the next i18n update.