Page MenuHomePhabricator

AndroidXmlFFS output should escape strings starting with "@"
Closed, ResolvedPublic

Description

Output of a string containing "@" in the middle in English but "@" at the start in Korean broke the Android app build: https://phabricator.wikimedia.org/T87628?workflow=create

Event Timeline

brooke raised the priority of this task from to Needs Triage.
brooke updated the task description. (Show Details)
brooke added subscribers: brooke, Aklapper.
gerritbot subscribed.

Change 186932 had a related patch set uploaded (by BearND):
Fix build/translations

https://gerrit.wikimedia.org/r/186932

Patch-For-Review

Linked ^ patch to the wrong bug number. The patch I submitted was just to fix the Android app build.

Change 186995 had a related patch set uploaded (by Brion VIBBER):
Escape '@' sign at beginning of strings to avoid compilation breakage.

https://gerrit.wikimedia.org/r/186995

Patch-For-Review

Nikerabbit renamed this task from Android FFS output should escape strings containing initial "@" char to AndroidXmlFFS output should escape strings starting with "@".Jan 28 2015, 5:51 AM
Nikerabbit assigned this task to brooke.
Nikerabbit triaged this task as High priority.

Change 186995 merged by jenkins-bot:
Escape '@' sign at beginning of strings to avoid compilation breakage.

https://gerrit.wikimedia.org/r/186995

Ok, the quick fix and the fix to Translate are now merged, so this should be safe for the next i18n update.