| Nemo_bis | |
| Jan 27 2015, 1:27 AM |
| F3057897: sc104.png | |
| Dec 8 2015, 7:58 AM |
| F2712165: search-section-interwiki.png | |
| Oct 12 2015, 8:38 AM |
A mobile user reports that interwiki search results come before normal results for them.
There is no interwiki search on m.wikipedia.org (nor full text search at all), so the user must be talking of the desktop site; indeed, if you take a busy result page and shrink the browser window, you can see that in the end the right div comes before the left div.
Should be trivial to switch the two HTML blocks.
See also: T18886: Sister projects search results box placement on IE7
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Nemo_bis | T87631 Interwiki search results should come after local ones in HTML | |||
| Resolved | • demon | T46420 Restore interwiki (sister projects) results in search queries |
Change 186915 had a related patch set uploaded (by Nemo bis):
Output local search results before interwiki results
Wouldn't this result in the interwiki search results being displayed below instead of to the side in the typical window-size case?
Change 186915 abandoned by Nemo bis:
Output local search results before interwiki results
Reason:
Per Brion
It's not Discovery's priority at present to support the current version of interwiki search on the Italian Wikipedia. You can look at our goals to see what we are working on.
Change 238808 had a related patch set uploaded (by Nemo bis):
Explicitly float local search results left so they come first
Change 238808 merged by jenkins-bot:
Explicitly float local search results left so they come first
@Nemo_bis: this patch has introduced a stray newline character below the results list (pl.wikisource).
The solution works but has a poor interaction with CirrusSearch adding section links, which can be very long. Here is how much I have to zoom out (50 %) in order to see the interwiki box for one specific search:
The section link should probably be pushed to the next line. Classes are available: searchalttitle for the span and mw-search-result-heading for the whole line.
The float-left, leads to a rather unpleasant side-effect, where the second <h2> moves to the right and the content below it (not seen in the screenshot) doesn't.
Thanks for the report. We didn't notice because that only happens with the vanilla MediaWiki MySQL search, which adds the headers without any separation:
$out->wrapWikiMsg( "==$1==\n", 'titlematches' ); [...] $out->wrapWikiMsg( "==$1==\n", 'textmatches' );
I have opened the new report, just referencing it for those who will still land here: https://phabricator.wikimedia.org/T122499