Page MenuHomePhabricator

Implement ECMAScript 5 Object.keys as polyfill for Internet Explorer 8
Closed, InvalidPublic

Description

Implement ECMAScript 5 Object.keys as polyfill: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Polyfill

Internet Explorer 8 does not support Object.keys.

Event Timeline

Fomafix raised the priority of this task from to Needs Triage.
Fomafix updated the task description. (Show Details)
Fomafix added a project: JavaScript.
Fomafix added a subscriber: Fomafix.

@Fomafix: Which software project is this about? ULS? MediaWiki core? Adding one is welcome.

MediaWiki core has the es5-shim module, which provides this method (among others). ULS should presumably just add a dependency on it.

es5-ship in core is the right position.

But es5-ship currently does not create Object.keys. This has to be implemented.

Then ULS can depend on es5-ship.

It most definitely does create Object.keys, the code is in /resources/lib/es5-shim/es5-shim.js starting on line 752 onward.

Fomafix claimed this task.

I read the wrong file. es5-shim already creates Object.keys.