Page MenuHomePhabricator
Create Task
Maniphest T87665

Implement ECMAScript 5 Object.keys as polyfill for Internet Explorer 8
Closed, InvalidPublic
Actions

Description

Implement ECMAScript 5 Object.keys as polyfill: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Polyfill

Internet Explorer 8 does not support Object.keys.

Event Timeline

Fomafix created this task.Jan 27 2015, 6:55 PM
Fomafix raised the priority of this task from to Needs Triage.
Fomafix updated the task description. (Show Details)
Fomafix added a project: JavaScript.
Fomafix subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2015, 6:55 PM
Fomafix added a subtask: T86516: UniversalLanguageSelector is not compatible with IE8.Jan 27 2015, 6:55 PM
Fomafix removed a subtask: T86516: UniversalLanguageSelector is not compatible with IE8.
Fomafix added a parent task: T86516: UniversalLanguageSelector is not compatible with IE8.
Aklapper added a comment.Jan 27 2015, 9:56 PM

@Fomafix: Which software project is this about? ULS? MediaWiki core? Adding one is welcome.

matmarex subscribed.Jan 28 2015, 10:44 AM

MediaWiki core has the es5-shim module, which provides this method (among others). ULS should presumably just add a dependency on it.

matmarex added a project: MediaWiki-General.Jan 28 2015, 10:44 AM
Fomafix added a comment.Jan 28 2015, 2:23 PM

es5-ship in core is the right position.

But es5-ship currently does not create Object.keys. This has to be implemented.

Then ULS can depend on es5-ship.

matmarex added a comment.Jan 29 2015, 6:26 PM

It most definitely does create Object.keys, the code is in /resources/lib/es5-shim/es5-shim.js starting on line 752 onward.

Fomafix closed this task as Invalid.Jan 29 2015, 6:38 PM
Fomafix claimed this task.

I read the wrong file. es5-shim already creates Object.keys.

Fomafix removed a parent task: T86516: UniversalLanguageSelector is not compatible with IE8.Jan 29 2015, 6:50 PM
Ricordisamoa subscribed.Feb 17 2016, 9:03 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptFeb 17 2016, 9:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits