Page MenuHomePhabricator
Create Task
Maniphest T87669

Look at using Lua for donatewiki
Closed, ResolvedPublic
Actions

Description

We have very complicated templates on donatewiki, that do things like read from GET query parameters. Perhaps we should consider porting some of the trickier stuff to Lua.

Event Timeline

awight created this task.Jan 27 2015, 7:55 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a project: Wikimedia-Fundraising.
awight added subscribers: awight, Pcoombe.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2015, 7:55 PM
• atgo added a project: Fundraising-Backlog-Old.Jan 27 2015, 9:17 PM
• atgo set Security to None.
• atgo subscribed.

@awight @Pcoombe what would merit this change? I'm trying to figure out priority.

Pcoombe added a comment.Jan 28 2015, 4:55 PM

Donate wiki is a bit of a mess, but it's stable. Also it's now only used for a small portion of donations (those not from banners).

Lua might help improve code maintainability, and slightly improve performance (?) but realistically I'd have to say this is a low priority.

• atgo added a project: Fundraising-Backlog.Jul 30 2015, 10:15 PM
• atgo removed a project: Wikimedia-Fundraising.Jul 30 2015, 10:48 PM
• atgo removed a project: Fundraising-Backlog.Jul 31 2015, 9:05 PM
• atgo unsubscribed.Mar 30 2016, 10:09 PM
• DStrine added a project: Fundraising-Backlog.Aug 5 2016, 8:49 PM
• DStrine moved this task from Triage to from tech backlog on the Fundraising-Backlog board.Aug 5 2016, 8:53 PM
• DStrine removed a subscriber: awight.Jun 22 2017, 9:13 PM
Pcoombe triaged this task as Low priority.Nov 7 2017, 3:53 PM
Pcoombe added a project: Wikimedia-Fundraising.
Pcoombe moved this task from Inbox to Donatewiki issues on the Wikimedia-Fundraising board.
Pcoombe edited projects, added donate.wikimedia.org; removed Wikimedia-Fundraising.Aug 2 2018, 2:28 PM
Pcoombe moved this task from Backlog to Donation forms on the donate.wikimedia.org board.Aug 7 2018, 10:49 AM
Pcoombe closed this task as Resolved.May 13 2019, 1:07 PM
Pcoombe claimed this task.

I've rewritten a few of the trickier templates to use Lua now. It does make the code much clearer, will probably do some more later.

https://donate.wikimedia.org/wiki/Module:Main

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL