Page MenuHomePhabricator
Create Task
Maniphest T87757

[Story] Add icons to text in toolbars
Closed, ResolvedPublic
Actions

Assigned To
• Jonas
Authored By
Tobi_WMDE_SW
Jan 28 2015, 1:06 PM
Tags
Subscribers
adrianheine
Aklapper
Bene
gerritbot
• Jonas
Lydia_Pintscher
Ricordisamoa
View All 10 Subscribers
Tokens
"Like" token, awarded by matej_suchanek."Dislike" token, awarded by thiemowmde."Dislike" token, awarded by Ricordisamoa."Like" token, awarded by Tobi_WMDE_SW."Love" token, awarded by Jonas.

Description

  • [Task] Make oojs-ui available in entity view
  • [Task] Add icons to edit, save, remove, cancel text-buttons and remove brackets (T113476)
  • [Task] Add icons to add qualifier add reference add statement text-button and remove brackets (T113476) (only replace "add")
  • [Task] Add icons to collapse text-buttons and remove brackets (T113476)

Reduce the button text size
Alt/Title text must be set to enable hint and screen readers

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+4 -0Add button icon when missing in the HTML template
mediawiki/extensions/Wikibasemaster+9 -3Also load button icons with JavaScript disabled
mediawiki/extensions/Wikibasemaster+19 -17Fix toolbar icon hover CSS
mediawiki/extensions/Wikibasemaster+187 -82Add icons to text in toolbars
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Jan 28 2015, 1:06 PM
Tobi_WMDE_SW raised the priority of this task from to Medium.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.
Tobi_WMDE_SW added subscribers: adrianheine, thiemowmde, Snaterlicious and 2 others.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jan 28 2015, 6:21 PM
• Jonas renamed this task from Replace text in toolbars with icons to [Story] Replace text in toolbars with icons.Sep 10 2015, 2:59 PM
• Jonas set Security to None.
• Jonas awarded a token.Sep 23 2015, 2:02 PM
• Jonas closed subtask T113476: [Task] Create Icons as Resolved.Sep 24 2015, 9:19 AM
• Jonas updated the task description. (Show Details)Sep 24 2015, 9:31 AM
Tobi_WMDE_SW awarded a token.Sep 24 2015, 9:34 AM
• Jonas updated the task description. (Show Details)Sep 24 2015, 9:44 AM
Ricordisamoa awarded a token.Sep 24 2015, 2:33 PM
Ricordisamoa added a subscriber: Ricordisamoa.
• Jonas updated the task description. (Show Details)Sep 25 2015, 9:45 AM
• Jonas updated the task description. (Show Details)
JanZerebecki added a project: Story.Sep 25 2015, 8:28 PM
• Jonas added a subscriber: • Jonas.Sep 26 2015, 6:47 PM

@Ricordisamoa could you please explain why you gave a thumps down?
Should the page stay text only? Or would you prefer to have icons in addition to text?

Ricordisamoa added a comment.Sep 30 2015, 4:06 AM
In T87757#1678519, @Jonas wrote:

@Ricordisamoa could you please explain why you gave a thumps down?
Should the page stay text only? Or would you prefer to have icons in addition to text?

Icons are based on design, rather than usability, grounds. Text is also clearer and less likely to mess the alignment up.

thiemowmde added a comment.Sep 30 2015, 5:08 PM

https://www.goodui.org/#47

I also heavily disagree with icon-only buttons. We currently have one (the trash can) which is kind of ok-ish, but we definitely should not have more of these. Look at what Visual Editor does. Icons + text, pretty much never an icon alone.

thiemowmde awarded a token.Sep 30 2015, 5:09 PM
• Jonas moved this task from ready to go to needs discussion or investigation on the Wikidata board.Oct 2 2015, 3:12 PM
• Jonas added a subscriber: Lydia_Pintscher.Oct 2 2015, 3:15 PM

I am totally fine with having icons additionally to the existing texts, but I really love to see icons on Wikidata.
So I am proposing this to be discussed in Story Time @Lydia_Pintscher

• Jonas renamed this task from [Story] Replace text in toolbars with icons to [Story] Add icons to text in toolbars (mockup).Oct 6 2015, 9:58 AM
• Jonas updated the task description. (Show Details)
Snaterlicious added a comment.Oct 19 2015, 3:03 PM

Snaterlicious added a comment.Oct 19 2015, 3:08 PM

• Jonas updated the task description. (Show Details)Oct 19 2015, 3:18 PM
• Jonas updated the task description. (Show Details)
• Jonas renamed this task from [Story] Add icons to text in toolbars (mockup) to [Story] Add icons to text in toolbars.Nov 2 2015, 1:26 PM
• Jonas added a project: Wikidata-Sprint-2015-11-03.
• Jonas moved this task from needs discussion or investigation to consider for next sprint on the Wikidata board.
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2015-11-03 board.Nov 3 2015, 2:14 PM
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Nov 8 2015, 5:01 PM
• Jonas claimed this task.Nov 11 2015, 2:34 PM
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-11-03 board.
gerritbot added a subscriber: gerritbot.Nov 11 2015, 2:46 PM

Change 252430 had a related patch set uploaded (by Jonas Kress (WMDE)):
Add icons to text in toolbars

https://gerrit.wikimedia.org/r/252430

gerritbot added a project: Patch-For-Review.Nov 11 2015, 2:46 PM
• Jonas updated the task description. (Show Details)Nov 11 2015, 2:58 PM

LTR not working at the moment.

• Jonas updated the task description. (Show Details)Nov 13 2015, 7:33 PM
• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2015-11-03 board.Nov 16 2015, 10:58 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-17.Nov 17 2015, 12:37 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-11-17 board.
• Jonas added a comment.Nov 19 2015, 3:04 PM

This is what it looks after cleaning up:

Lydia_Pintscher added a comment.Nov 19 2015, 6:57 PM

\o/

matej_suchanek awarded a token.Nov 19 2015, 7:07 PM
• Jonas updated the task description. (Show Details)Nov 20 2015, 4:14 PM
Bene added a subscriber: Bene.Nov 21 2015, 2:15 PM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-12-01.Dec 1 2015, 10:10 AM
Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2015-12-01 board.
Bene added a comment.Dec 1 2015, 2:42 PM

At least two gadgets (written by me) add custom edit links to the ui. They are called the Move.js and DuplicateReferences.js. We need to adopt them to the new ui by removing brackets or pipes they add and by giving them icons which fit them.

gerritbot added a comment.Dec 2 2015, 11:29 AM

Change 252430 merged by jenkins-bot:
Add icons to text in toolbars

https://gerrit.wikimedia.org/r/252430

• Jonas closed this task as Resolved.Dec 2 2015, 11:35 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-11-17 board.
Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-12-01 board.Dec 3 2015, 9:49 AM
gerritbot added a comment.Dec 3 2015, 4:44 PM

Change 256711 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix toolbar icon hover CSS

https://gerrit.wikimedia.org/r/256711

gerritbot added a comment.Dec 4 2015, 10:46 AM

Change 256711 merged by jenkins-bot:
Fix toolbar icon hover CSS

https://gerrit.wikimedia.org/r/256711

gerritbot added a comment.Dec 7 2015, 1:55 PM

Change 257312 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Also load button icons with JavaScript disabled

https://gerrit.wikimedia.org/r/257312

gerritbot added a comment.Dec 7 2015, 2:49 PM

Change 257312 merged by jenkins-bot:
Also load button icons with JavaScript disabled

https://gerrit.wikimedia.org/r/257312

gerritbot added a comment.Dec 9 2015, 3:00 PM

Change 257890 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add button icon when missing in the HTML template

https://gerrit.wikimedia.org/r/257890

gerritbot added a comment.Jan 12 2016, 12:59 PM

Change 257890 abandoned by Thiemo Mättig (WMDE):
Add button icon when missing in the HTML template

Reason:
Obsolete via Ifc81a47 and per FIXME.

https://gerrit.wikimedia.org/r/257890

inyono closed subtask T123511: [Task] adapt primary sources tool to text/icon changes as Resolved.Mar 1 2016, 1:38 PM
inyono reopened subtask T123511: [Task] adapt primary sources tool to text/icon changes as Open.Mar 1 2016, 2:45 PM
Tobi_WMDE_SW closed subtask T123511: [Task] adapt primary sources tool to text/icon changes as Resolved.Mar 1 2016, 4:14 PM
thiemowmde mentioned this in T158059: harmonize UI for sitelink boxes’ collapse/expand .Nov 21 2017, 12:03 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL