Page MenuHomePhabricator

Add Multimedia team members as reviewers to multimedia-related Gerrit patches
Closed, InvalidPublic

Description

As a step towards improving code review responsiveness, we should make sure MM team members know about commits they would be able to review - right now volunteer patches, especially to MediaWiki core, can be stalled for a long time.

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: Multimedia, Gerrit-Migration.
Tgr subscribed.

Is this some technical request or a social one? For the latter and our current infrastructure: https://gerrit.wikimedia.org/r/#/settings/projects
(Plus wondering what would be detectable criteria for this task to declare it "resolved" at some point)

Mostly a reminder for myself to figure out how Reviewer-bot works / where the code is stored.

Gerrit does not allow file name filtering AFAIK (T63463).

From T86318, the repos we should watch are:

  • mediawiki/extensions/CommonsMetadata
  • mediawiki/extensions/GlobalUsage
  • mediawiki/extensions/GWToolset
  • mediawiki/extensions/ImageMap
  • mediawiki/extensions/ImageMetrics
  • mediawiki/extensions/MolHandler
  • mediawiki/extensions/MultimediaViewer
  • mediawiki/extensions/MultiUpload
  • mediawiki/extensions/PagedTiffHandler
  • mediawiki/extensions/PdfHandler
  • mediawiki/extensions/PronunciationRecording
  • mediawiki/extensions/Score
  • mediawiki/extensions/Sentry
  • mediawiki/extensions/TimedMediaHandler
  • mediawiki/extensions/UploadWizard
  • mediawiki/extensions/VipsScaler

The multimedia-related core files are

  • mediawiki/core
    • img_auth.php, thumb.php, thumb_handler.php
    • images/*
    • includes/MimeMagic.php, includes/mime.*
    • includes/StreamFile.php
    • includes/api/ApiQueryImageInfo.php
    • includes/filebackend/*
    • includes/filerepo/*
    • includes/gallery/*
    • includes/libs/IE*
    • includes/media/*
    • includes/page/WikiFilePage.php, includes/page/ImagePage.php
    • includes/upload/*

There are probably a couple more api/specialpage classes, but this should be the gist of it.

Tgr claimed this task.

No Multimedia team anymore...