Page MenuHomePhabricator
Create Task
Maniphest T87786

in language screenshots there must be a way to add more padding around the element that is being cropped
Closed, ResolvedPublic
Actions

Description

It is sometimes required to add some more pixels around the element that is being cropped. Currently only the element is cropped.

Some examples where it can be useful:
https://www.mediawiki.org/wiki/File:VisualEditor_-_Edit_tab.png
https://www.mediawiki.org/wiki/File:VisualEditor_-_Section_edit_links.png
https://www.mediawiki.org/wiki/File:VisualEditor_-_Edit_tab_-_Rus.png
https://www.mediawiki.org/wiki/File:VisualEditor_-_Section_edit_links_Rus.png

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BrowserTest] Update the screenshot gem versionmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jan 28 2015, 7:08 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: VisualEditor, Browser-test-bug.
Amire80 added subscribers: Amire80, zeljkofilipin.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2015, 7:08 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 28 2015, 11:46 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Amire80 added a subscriber: Vikassy.Feb 23 2015, 1:03 PM
Amire80 assigned this task to Vikassy.Feb 23 2015, 1:44 PM

Assigning to @Vikassy, who volunteered on IRC :)

This will probably have to be changed in the screenshot gem.

Amire80 renamed this task from in language screenshots there must be a way to add more margins around the element that is being cropped to in language screenshots there must be a way to add more padding around the element that is being cropped.Mar 19 2015, 1:16 PM
Amire80 claimed this task.

@zeljkofilipin eventually did it differently - by removing all iframe support and adding simple padding on all sides.

Upstream pull request: https://github.com/amire80/screenshot/pull/11

gerritbot subscribed.Mar 19 2015, 1:21 PM

Change 197898 had a related patch set uploaded (by Amire80):
[BrowserTest] Update the screenshot gem version

https://gerrit.wikimedia.org/r/197898

gerritbot added a project: Patch-For-Review.Mar 19 2015, 1:21 PM
Amire80 closed this task as Resolved.Mar 19 2015, 1:24 PM

Resolved with help from @zeljkofilipin and @Vikassy. I'll add the actual padding to relevant scenarios in separate commits.

gerritbot added a comment.Mar 19 2015, 1:24 PM

Change 197898 merged by jenkins-bot:
[BrowserTest] Update the screenshot gem version

https://gerrit.wikimedia.org/r/197898

Jdforrester-WMF removed a project: Patch-For-Review.Mar 20 2015, 11:32 PM
Amire80 mentioned this in rEVEDda14d93cee1f: [BrowserTest] Update the screenshot gem version.Mar 23 2015, 3:54 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 1:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits