Page MenuHomePhabricator

in language screenshots there must be a way to add more padding around the element that is being cropped
Closed, ResolvedPublic

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, zeljkofilipin.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

Assigning to @Vikassy, who volunteered on IRC :)

This will probably have to be changed in the screenshot gem.

Amire80 renamed this task from in language screenshots there must be a way to add more margins around the element that is being cropped to in language screenshots there must be a way to add more padding around the element that is being cropped.Mar 19 2015, 1:16 PM
Amire80 claimed this task.

@zeljkofilipin eventually did it differently - by removing all iframe support and adding simple padding on all sides.

Upstream pull request: https://github.com/amire80/screenshot/pull/11

Change 197898 had a related patch set uploaded (by Amire80):
[BrowserTest] Update the screenshot gem version

https://gerrit.wikimedia.org/r/197898

Resolved with help from @zeljkofilipin and @Vikassy. I'll add the actual padding to relevant scenarios in separate commits.

Change 197898 merged by jenkins-bot:
[BrowserTest] Update the screenshot gem version

https://gerrit.wikimedia.org/r/197898