Page MenuHomePhabricator
Create Task
Maniphest T87818

Toolbar menus don't disappear when another menu is opened on touch devices
Closed, ResolvedPublic
Actions

Description

Toolbar menus don't disappear when another menu is opened on touch devices, by touching the toolbar button. This doesn't happen when using an extermal mouse to click on the same device, or on desktop.

Confirmed on a Thinkpad Tablet 2 (running Windows 8.1) and some iPad thing.

Details

SubjectRepoBranchLines +/-
Remove half-baked touch event handlingoojs/uimaster+9 -14
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 28 2015, 11:02 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2015, 11:02 PM
matmarex added a comment.Jan 28 2015, 11:03 PM

http://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#toolbars-apex-vector-ltr

Capture.PNG (768×1 px, 180 KB)

Jdforrester-WMF triaged this task as High priority.Feb 2 2015, 3:33 AM
matmarex lowered the priority of this task from High to Medium.Feb 5 2015, 5:14 PM
TheDJ subscribed.Feb 18 2015, 9:35 AM

This is also reproducible if you use keyboard navigation btw.

matmarex mentioned this in T91757: Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices.Mar 6 2015, 8:33 PM
Nnemo subscribed.Mar 7 2015, 8:56 AM
matmarex claimed this task.Mar 7 2015, 9:24 PM
gerritbot subscribed.Mar 7 2015, 9:24 PM

Change 195067 had a related patch set uploaded (by Bartosz Dziewoński):
Remove half-baked touch event handling

https://gerrit.wikimedia.org/r/195067

gerritbot added a project: Patch-For-Review.Mar 7 2015, 9:24 PM
gerritbot added a comment.Mar 9 2015, 9:38 PM

Change 195067 merged by jenkins-bot:
Remove half-baked touch event handling

https://gerrit.wikimedia.org/r/195067

matmarex mentioned this in rGOJU406f62b8c731: Remove half-baked touch event handling.Mar 9 2015, 9:38 PM
Jdforrester-WMF closed this task as Resolved.Mar 9 2015, 9:44 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.1), WMF-deploy-2015-03-18_(1.25wmf22); removed OOjs-UI-next-release.Mar 12 2015, 8:57 PM
Etonkovidova subscribed.Mar 24 2015, 8:32 PM

Checked the fix along with T91757 - the issue has been fixed.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL