Page MenuHomePhabricator
Create Task
Maniphest T87835

OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this
Closed, ResolvedPublic
Actions

Description

All MenuOptionWidget have a check icon. This icon is hidden in the normal state and shown in the selected state, regardless of the theme being used. When adjusting the selected state of the MenuOptionWidget for the MediaWiki theme in rGOJU873bfeb208646cd24cf7f92d357336b38865b72e, we decided to not show the check icon in the selected state either (for the MediaWiki theme only). Currently in a DropdownWidget the MenuOptionWidget looks like this:

Apex (with icon)MediaWiki (without icon
Screen Shot 2017-03-27 at 12.25.18 PM.png (242×663 px, 24 KB)
Screen Shot 2017-03-27 at 12.26.15 PM.png (238×666 px, 24 KB)

So this check icon is only being used by the Apex theme and is still being added everywhere. To fix this we could remove the check icon from MenuSectionOption widget, and:

  1. ...have Apex add it through CSS (like mediawiki theme does with Tool, see below)
  2. ...change the way the selected state looks like in Apex:
    • ...to match the mediawiki theme
    • ...to have a gray background when the option is selected
    • ideas?

This icon should not be confused with the check icon seen in Tool in the mediawiki theme. It's not added through javascript (like in the case of MenuOptionWidget), and is only added in the mediawiki theme.

Details

SubjectRepoBranchLines +/-
MenuOptionWidget: Remove theme-independent 'check' iconoojs/uimaster+17 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jan 29 2015, 1:47 AM
matmarex assigned this task to • TrevorParscal.
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex added subscribers: matmarex, • Prtksxna.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2015, 1:48 AM
Jdforrester-WMF triaged this task as Medium priority.Jan 29 2015, 1:53 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Jan 29 2015, 10:02 PM
matmarex lowered the priority of this task from Medium to Low.Feb 5 2015, 5:30 PM
Jdforrester-WMF removed • TrevorParscal as the assignee of this task.May 30 2015, 7:39 PM
matmarex mentioned this in T101560: OO.ui.MenuOptionWidget's icons are hidden in the mediawiki theme in the selected state and can't be used.Jun 6 2015, 11:01 AM
matmarex added a project: Technical-Debt.
matmarex added a parent task: T101560: OO.ui.MenuOptionWidget's icons are hidden in the mediawiki theme in the selected state and can't be used.
• Prtksxna updated the task description. (Show Details)Mar 27 2017, 7:37 AM
• Prtksxna added a subscriber: Volker_E.
Volker_E added a comment.Mar 27 2017, 7:44 AM

@Prtksxna Thanks for the task description update. I've forgot about the check in MenuToolGroup/MediaWiki. Personally I'd prefer a CSS-only solution from an architectural view, if I don't miss out something technical important.

• Prtksxna added a subscriber: Esanders.Mar 27 2017, 7:59 AM

@Esanders what would be your preferred solution? Is adding the check through CSS in Apex okay?

Volker_E added a subscriber: Mooeypoo.Apr 6 2017, 3:39 AM
Volker_E added a comment.Apr 6 2017, 10:40 PM

From IRC chat @Prtksxna :

Volker_E> edsanders: check icon through CSS-only ok from your POV? https://phabricator.wikimedia.org/T87835
edsanders> Seems ok - would it prevent menu options from having other icons?
Volker_E> edsanders: no, it needs to be able to still take any icon as intended

gerritbot subscribed.Apr 13 2017, 4:41 PM

Change 348098 had a related patch set uploaded (by Prtksxna):
[oojs/ui@master] MenuOptionWidget: Stop adding check icon

https://gerrit.wikimedia.org/r/348098

gerritbot added a project: Patch-For-Review.Apr 13 2017, 4:41 PM
• Prtksxna claimed this task.Apr 13 2017, 4:45 PM
gerritbot added a comment.Apr 15 2017, 7:03 AM

Change 348098 merged by jenkins-bot:
[oojs/ui@master] MenuOptionWidget: Remove theme-independent 'check' icon

https://gerrit.wikimedia.org/r/348098

Volker_E moved this task from Next-up to OOjs-UI-0.21.1 on the OOUI board.Apr 15 2017, 7:03 AM
Volker_E edited projects, added OOUI (OOjs-UI-0.21.1); removed OOUI.
Volker_E closed this task as Resolved.Apr 15 2017, 7:20 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E removed a subscriber: gerritbot.
Volker_E mentioned this in T162830: [Regression pre-wmf.21] The padding for table cell menu items got narrower, making it looked crammed, due to OOUI 0.21.0 release.Apr 17 2017, 3:39 AM
• Prtksxna mentioned this in T163104: OOjs UI WikimediaUI theme: MenuOption: Adding an icon misaligns the option with the rest.Apr 17 2017, 11:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL