Page MenuHomePhabricator
Create Task
Maniphest T87876

Convert AbuseFilter to use extension registration
Closed, ResolvedPublic
Actions

Description

The AbuseFilter extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/AbuseFilterREL1_27+311 -200Add extension.json, empty php entry point
mediawiki/extensions/AbuseFiltermaster+311 -200Add extension.json, empty php entry point
mediawiki/extensions/AbuseFiltermaster+411 -231Add extension registration and following changes
mediawiki/extensions/AbuseFiltermaster+311 -200Add extension.json, empty php entry point
mediawiki/extensions/AbuseFiltermaster+268 -0Add extension.json
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
ResolvedTgrT110448 Update AbuseFilter to use AuthManager
ResolvedTgrT87876 Convert AbuseFilter to use extension registration
· · ·

Event Timeline

Legoktm added a subscriber: Legoktm.Jan 29 2015, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2015, 7:18 PM
Legoktm updated the task description. (Show Details)Jan 29 2015, 7:19 PM
Legoktm added a project: AbuseFilter.
Legoktm set Security to None.
Legoktm added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Jan 29 2015, 7:59 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Jan 30 2015, 4:05 AM
gerritbot added a project: Patch-For-Review.Feb 16 2015, 1:50 AM
gerritbot added a subscriber: gerritbot.

Change 190761 had a related patch set uploaded (by Se4598):
Convert AbuseFilter to use extension registration system

https://gerrit.wikimedia.org/r/190761

Patch-For-Review

Se4598 claimed this task.Feb 16 2015, 3:02 AM
Se4598 triaged this task as Low priority.
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Feb 16 2015, 3:03 AM
gerritbot added a comment.Jul 2 2015, 10:10 AM

Change 190761 abandoned by Se4598:
Add extension.json

Reason:
I don't have the will and time to maintain this change for all the other changes happening while this was up in the past and would be up in the future... Don't rely on this ps.

https://gerrit.wikimedia.org/r/190761

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJul 2 2015, 10:10 AM
Se4598 removed Se4598 as the assignee of this task.Jul 2 2015, 10:11 AM
Krenair removed a project: Patch-For-Review.Jul 2 2015, 2:29 PM
gerritbot added a comment.Jul 3 2015, 11:19 AM

Change 222566 had a related patch set uploaded (by Paladox):
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/222566

gerritbot added a project: Patch-For-Review.Jul 3 2015, 11:19 AM
gerritbot added a comment.May 31 2016, 3:40 PM

Change 222566 merged by jenkins-bot:
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/222566

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 3:01 AM
gerritbot added a comment.Jun 3 2016, 3:11 PM

Change 292569 had a related patch set uploaded (by Paladox):
Add extension registration and following changes

https://gerrit.wikimedia.org/r/292569

Tgr mentioned this in T136644: Notice: Undefined variable: wgAbuseFilterAvailableActions in /srv/mediawiki/wmf-config/abusefilter.php on line 23.Jun 3 2016, 3:36 PM
Tgr added a subscriber: Tgr.Jun 3 2016, 3:39 PM

e71808f4c4deca416ecd39160d12f2584bfb9d65 did this but had to be reverted (see T136644 and T136929).

In T136644#2342749, @Legoktm wrote:

"AbuseFilterAvailableActions" should be converted to an associative array, so in config the things that need to be disabled can be set to => false instead of requiring array_diff and whatnot, and any calling code that needs to read from $wgAbuseFilterAvailableActions can use array_keys( array_filter( ... ) ); first.

matmarex mentioned this in T110448: Update AbuseFilter to use AuthManager.Jun 3 2016, 4:35 PM
matmarex added a parent task: T110448: Update AbuseFilter to use AuthManager.
matmarex added a subscriber: matmarex.Jun 3 2016, 4:37 PM
gerritbot added a comment.Jun 3 2016, 7:08 PM

Change 292604 had a related patch set uploaded (by Gergő Tisza):
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/292604

Tgr added a comment.Jun 3 2016, 7:19 PM

Tried to update those config fields to associative but preserve B/C with a somewhat ugly hack in https://gerrit.wikimedia.org/r/#/c/292605/.

MGChecker added a subscriber: MGChecker.Jun 5 2016, 5:56 PM
Paladox assigned this task to Tgr.Jun 7 2016, 2:23 PM
Paladox added a subscriber: Paladox.

@Tgr I've assigned you to this task since you fixed the problem. If you doint want to be assigned please unassign your self.

gerritbot added a comment.Jun 7 2016, 2:32 PM

Change 292604 merged by jenkins-bot:
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/292604

Tgr closed this task as Resolved.Jun 7 2016, 2:32 PM

Let's hope it sticks this time.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 5:00 PM
gerritbot added a comment.Jun 8 2016, 8:00 PM

Change 292569 abandoned by Paladox:
Add extension registration and following changes

https://gerrit.wikimedia.org/r/292569

gerritbot added a comment.Jul 20 2016, 2:11 AM

Change 299931 had a related patch set uploaded (by Gergő Tisza):
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/299931

gerritbot added a comment.Jul 20 2016, 2:25 AM

Change 299931 merged by jenkins-bot:
Add extension.json, empty php entry point

https://gerrit.wikimedia.org/r/299931

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL