Page MenuHomePhabricator
Create Task
Maniphest T87899

Convert Collection to use extension registration
Closed, ResolvedPublic
Actions

Description

The Collection extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Collectionmaster+3 -0Disable wfWarn() in extension entry point
operations/mediawiki-configmaster+1 -1Load Collection from extension.json directly
mediawiki/extensions/Collectionwmf/1.34.0-wmf.13+3 -0Disable wfWarn() in extension entry point
mediawiki/extensions/Collectionwmf/1.34.0-wmf.14+3 -0Disable wfWarn() in extension entry point
mediawiki/extensions/Collectionmaster+15 -12Finish migration to extension.json
mediawiki/extensions/Collectionmaster+262 -265Add extension-wip.json
mediawiki/extensions/Collectionmaster+265 -270Add extension.json, empty entry point
mediawiki/extensions/Collectionmaster+258 -253Move all functions into CollectionAjaxFunctions file in preparation for extension.json
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
ResolvedRelease• LarsWirzeniusT220740 1.34.0-wmf.15 deployment blockers
ResolvedReedyT87899 Convert Collection to use extension registration
· · ·

Event Timeline

Legoktm added a project: Collection.Jan 29 2015, 7:31 PM
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2015, 7:31 PM
Krenair added a subscriber: Krenair.Jan 29 2015, 7:56 PM
Legoktm added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Jan 29 2015, 7:59 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Feb 2 2015, 3:56 AM
Liuxinyu970226 updated the task description. (Show Details)Sep 6 2015, 11:08 PM
Liuxinyu970226 set Security to None.
Florian added a project: Google-Code-In-2015.Dec 17 2015, 10:28 PM
Florian added a subscriber: Florian.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 17 2015, 10:28 PM
Florian added a comment.Dec 17 2015, 10:28 PM

https://codein.withgoogle.com/dashboard/tasks/5206567611793408/

Florian moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 17 2015, 10:28 PM
Legoktm added a comment.Dec 17 2015, 10:30 PM

Collection can't be ported until the usage of $wgAjaxExportList is removed.

Legoktm added a subtask: T94005: Remove AjaxDispatcher use from Collection.Dec 17 2015, 10:31 PM
Florian moved this task from Imported into GCI site to Clarification required on the Google-Code-In-2015 board.Dec 17 2015, 10:34 PM
Ricordisamoa added a subscriber: Ricordisamoa.Mar 5 2016, 7:24 PM
gerritbot added a subscriber: gerritbot.Aug 11 2016, 1:18 PM

Change 304206 had a related patch set uploaded (by Paladox):
Move all functions into hooks file in preparation for extension.json

https://gerrit.wikimedia.org/r/304206

gerritbot added a project: Patch-For-Review.Aug 11 2016, 1:18 PM
gerritbot added a comment.Aug 11 2016, 1:38 PM

Change 304226 had a related patch set uploaded (by Paladox):
Add extension.json, empty entry point

https://gerrit.wikimedia.org/r/304226

Paladox added a subscriber: Paladox.Aug 11 2016, 2:10 PM

@Legoktm but could we just $wgAjaxExportList port that to extension.json even though it is deprecated please?

Reedy triaged this task as Medium priority.Nov 27 2016, 10:42 PM
gerritbot added a comment.Jan 3 2017, 6:44 PM

Change 304206 merged by jenkins-bot:
Move all functions into CollectionAjaxFunctions file in preparation for extension.json

https://gerrit.wikimedia.org/r/304206

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 3 2017, 7:00 PM
Reedy removed projects: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Google-Code-In-2015.Mar 7 2017, 3:59 PM
Joergi123 added a subscriber: Joergi123.Jul 20 2017, 7:49 AM

The above patch has been reverted.

A new patch set is available at 332929:

Change 332929 had a related patch set uploaded
https://gerrit.wikimedia.org/r/#/c/332929/

What's the status there, guys?

Jdlrobson added a project: Readers-Web-Backlog.Sep 5 2017, 7:05 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.Sep 5 2017, 7:44 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Readers-Web-Backlog board.Sep 27 2017, 9:55 PM
Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.
Jdlrobson moved this task from Untriaged to Move to Backlog on the Readers-Web-Backlog (Tracking) board.Sep 28 2017, 7:35 PM
MarcoAurelio mentioned this in T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Nov 18 2017, 6:15 PM
Izno mentioned this in T140852: Load all Wikimedia-deployed extensions and skins via extension registration.Sep 11 2018, 7:52 PM
Krinkle edited parent tasks, added: T140852: Load all Wikimedia-deployed extensions and skins via extension registration; removed: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 11 2018, 9:32 PM
Krinkle added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 12 2018, 6:29 AM
Krinkle removed a parent task: T140852: Load all Wikimedia-deployed extensions and skins via extension registration.
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Sep 12 2018, 10:42 AM
gerritbot added a comment.May 17 2019, 10:59 PM

Change 304226 abandoned by Reedy:
Add extension.json, empty entry point

https://gerrit.wikimedia.org/r/304226

gerritbot added a comment.May 17 2019, 10:59 PM

Change 510984 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Collection@master] Add extension-wip.json

https://gerrit.wikimedia.org/r/510984

gerritbot added a comment.May 18 2019, 8:20 AM

Change 510984 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Add extension-wip.json

https://gerrit.wikimedia.org/r/510984

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 18 2019, 9:00 AM
gerritbot added a comment.May 29 2019, 3:15 PM

Change 511014 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/extensions/Collection@master] Finish migration to extension.json

https://gerrit.wikimedia.org/r/511014

gerritbot added a comment.May 29 2019, 3:47 PM

Change 511014 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Finish migration to extension.json

https://gerrit.wikimedia.org/r/511014

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 29 2019, 4:01 PM
Joergi123 removed a subscriber: Joergi123.May 30 2019, 9:45 AM
Krinkle edited projects, added Performance-Team (Radar); removed Patch-For-Review.Jul 19 2019, 2:16 PM
Krinkle added a subscriber: Krinkle.

As of recent, flame graphs for MediaWiki initialisation show MWDebug::warn and Monolog initialisation happening very early in the critical path.

Screenshot 2019-07-19 at 15.13.50.png (660×2 px, 182 KB)

Via WikimediaDebug with verbose logging enabled, I believe this is from the following:

Deprecated PHP entry point used for Collection extension. Please use wfLoadExtension instead, see https://www.mediawiki.org/wiki/Extension_registration for more details. [Called from include in /srv/mediawiki/php-1.34.0-wmf.13/extensions/Collection/Collection.php at line 33]

I don't know whether the wmf-config inclusion is trivial to move (there's generally always some amount of risk, complication, and low confidence due to variable ordering and precedence changing). But for the time being would be best to comment this out again.

gerritbot added a comment.Jul 19 2019, 2:17 PM

Change 524521 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Collection@master] Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524521

gerritbot added a project: Patch-For-Review.Jul 19 2019, 2:17 PM

Change 524522 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Collection@wmf/1.34.0-wmf.13] Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524522

gerritbot added a comment.Jul 19 2019, 2:18 PM

Change 524523 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Collection@wmf/1.34.0-wmf.14] Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524523

Krinkle added a comment.Jul 19 2019, 2:18 PM

I'll leave it untouched in master for now, so that we don't have to go back-and-forth multiple times if this is resolved before Tuesday. Otherwise, should land in master (and wmf.15) as well.

Krinkle added a parent task: T220740: 1.34.0-wmf.15 deployment blockers.Jul 19 2019, 2:19 PM
gerritbot added a comment.Jul 19 2019, 2:22 PM

Change 524523 merged by jenkins-bot:
[mediawiki/extensions/Collection@wmf/1.34.0-wmf.14] Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524523

Krinkle mentioned this in rECOL90eed0fadab3: Disable wfWarn() in extension entry point.Jul 19 2019, 2:25 PM
gerritbot added a comment.Jul 19 2019, 2:32 PM

Change 524522 merged by Krinkle:
[mediawiki/extensions/Collection@wmf/1.34.0-wmf.13] Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524522

Krinkle mentioned this in rECOL66ce154d7d73: Disable wfWarn() in extension entry point.Jul 19 2019, 2:34 PM
Stashbot added a comment.Jul 19 2019, 2:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-19T14:35:20Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.13/extensions/Collection/Collection.php: rECOL66ce154d7d73 / T87899 (duration: 00m 56s)

Stashbot added a comment.Jul 19 2019, 2:42 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-19T14:42:22Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.14/extensions/Collection/Collection.php: rECOL90eed0fadab3 / T87899 (duration: 00m 54s)

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jul 19 2019, 2:43 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jul 19 2019, 3:00 PM
gerritbot added a comment.Jul 19 2019, 4:50 PM

Change 524557 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Load Collection from extension.json directly

https://gerrit.wikimedia.org/r/524557

gerritbot added a comment.Jul 22 2019, 4:49 PM

Change 524557 merged by jenkins-bot:
[operations/mediawiki-config@master] Load Collection from extension.json directly

https://gerrit.wikimedia.org/r/524557

Stashbot added a comment.Jul 22 2019, 4:55 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-22T16:55:25Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: T87899 Use wfLoadExtension for Collection rather than deprecated entry point (duration: 00m 47s)

Jdforrester-WMF closed this task as Resolved.Jul 22 2019, 4:56 PM
Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF removed a subtask: T94005: Remove AjaxDispatcher use from Collection.
gerritbot added a comment.Jul 28 2019, 3:20 PM

Change 524521 abandoned by Krinkle:
Disable wfWarn() in extension entry point

https://gerrit.wikimedia.org/r/524521

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL