Page MenuHomePhabricator
Create Task
Maniphest T87981

Convert TimedMediaHandler to use extension registration
Closed, ResolvedPublic
Actions

Description

The TimedMediaHandler extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BREAKING CHANGE] Convert to extension.jsonmediawiki/extensions/TimedMediaHandlerREL1_31+387 -438
Migrate in all the MwEmbedSupport extension's code so we can kill it offmediawiki/extensions/TimedMediaHandlerREL1_31+6 K -10
[BREAKING CHANGE] Convert to extension.jsonmediawiki/extensions/TimedMediaHandlerwmf/1.32.0-wmf.14+387 -438
[BREAKING CHANGE] Convert to extension.jsonmediawiki/extensions/TimedMediaHandlermaster+387 -438
Migrate in all the MwEmbedSupport extension's code so we can kill it offmediawiki/extensions/TimedMediaHandlermaster+6 K -10
Convert to extension registrationmediawiki/extensions/TimedMediaHandlermaster+592 -648
Add extensions.json, empty PHP entry pointmediawiki/extensions/TimedMediaHandlermaster+825 -483
Convert ResouceLoader to use ResourceLoaderRegisterModules hookmediawiki/extensions/TimedMediaHandlermaster+169 -162
Improve dynamic resource module registrationmediawiki/extensions/TimedMediaHandlermaster+148 -129
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm added a project: TimedMediaHandler.Jan 29 2015, 7:33 PM
Legoktm subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 29 2015, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Jan 29 2015, 7:37 PM
Liuxinyu970226 subscribed.Feb 2 2015, 4:05 AM
gerritbot subscribed.May 11 2015, 8:26 PM

Change 210176 had a related patch set uploaded (by Paladox):
Add extensions.json, empty PHP entry point, remove i18n shim

https://gerrit.wikimedia.org/r/210176

gerritbot added a project: Patch-For-Review.May 11 2015, 8:26 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:03 PM
Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 4:01 PM
Liuxinyu970226 updated the task description. (Show Details)Oct 1 2015, 5:44 AM
Liuxinyu970226 set Security to None.
TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.Oct 25 2015, 1:34 PM
TheDJ assigned this task to Paladox.Oct 27 2015, 8:34 AM
TheDJ subscribed.
TheDJ added a subtask: T123823: Renumber commons TimedText namespace 102 to 710.Jan 29 2016, 10:43 AM
TheDJ removed a subtask: T123823: Renumber commons TimedText namespace 102 to 710.Feb 12 2016, 7:39 AM

unblocked because T90282 was properly fixed now.

TheDJ added a comment.Feb 18 2016, 2:53 PM

Note: we could move the conditional resource loader definitions from the extension registration function into a use https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules hook. That brings us another step closer.

Paladox added a comment.Feb 18 2016, 2:58 PM

@TheDJ do you mean before the migration or when we are converting or after.

TheDJ added subtasks: T123849: Transcodes in formats removed from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet not automatically removed, T118080: Rewrite $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet settings as a map from transcode to boolean for enabled status.EditedFeb 18 2016, 3:17 PM

I suggest we do that now, before conversion.

Paladox added a comment.Feb 18 2016, 3:46 PM

@TheDJ does that mean we can move the hooks also out of the function and back into the main php file.

gerritbot added a comment.Feb 18 2016, 3:59 PM

Change 271538 had a related patch set uploaded (by Paladox):
Convert ResouceLoader to use ResourceLoaderRegisterModules hook

https://gerrit.wikimedia.org/r/271538

Paladox added a comment.Feb 18 2016, 4:14 PM

@TheDJ anyways the extension function config is supported in extension registration, but what needs fixing is the transcode configs maybe a overhaul of them.

gerritbot added a comment.Feb 21 2016, 11:24 PM

Change 272422 had a related patch set uploaded (by TheDJ):
Improve dynamic resource module registration

https://gerrit.wikimedia.org/r/272422

gerritbot added a comment.Feb 26 2016, 4:35 PM

Change 272422 merged by jenkins-bot:
Improve dynamic resource module registration

https://gerrit.wikimedia.org/r/272422

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 26 2016, 5:00 PM
TheDJ removed a project: Patch-For-Review.Feb 26 2016, 6:26 PM
TheDJ added a subscriber: Paladox.
Paladox added a comment.EditedFeb 26 2016, 6:31 PM

We need to some have to update the code to allow the config to say which files can be found and if for example webm 360p was not included then that file should not be included in the transcodes even if the transcode is avalible, it should just be hidden and have the ability for a clear button.

gerritbot added a comment.Feb 26 2016, 6:34 PM

Change 271538 abandoned by Paladox:
Convert ResouceLoader to use ResourceLoaderRegisterModules hook

https://gerrit.wikimedia.org/r/271538

Paladox added subscribers: • brooke, Reedy.Aug 11 2016, 11:09 AM
gerritbot added a comment.Nov 21 2016, 1:45 AM

Change 210176 abandoned by Reedy:
Add extensions.json, empty PHP entry point

Reason:
to be redone

https://gerrit.wikimedia.org/r/210176

gerritbot added a comment.Nov 21 2016, 1:58 AM

Change 322609 had a related patch set uploaded (by Reedy):
Convert to extension registration

https://gerrit.wikimedia.org/r/322609

gerritbot added a project: Patch-For-Review.Nov 21 2016, 1:58 AM
Reedy removed projects: Patch-For-Review, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Mar 7 2017, 4:00 PM
gerritbot added a comment.May 4 2017, 8:30 PM

Change 350758 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] WIP: Migrate in all the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/350758

gerritbot added a project: Patch-For-Review.May 4 2017, 8:30 PM
gerritbot added a comment.Jul 29 2017, 5:37 PM

Change 322609 abandoned by Reedy:
Convert to extension registration

https://gerrit.wikimedia.org/r/322609

MarcoAurelio mentioned this in T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Nov 18 2017, 6:15 PM
Ebe123 subscribed.Dec 30 2017, 3:36 AM
• brooke closed subtask T123849: Transcodes in formats removed from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet not automatically removed as Declined.Jan 9 2018, 9:47 PM
Jdforrester-WMF mentioned this in T142121: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for WMF extensions that have been converted to extension registration.Jan 19 2018, 6:16 PM
Jayprakash12345 removed a project: Patch-For-Review.Mar 24 2018, 4:07 AM
Liuxinyu970226 unsubscribed.Apr 16 2018, 4:00 AM
gerritbot added a comment.Jun 22 2018, 12:24 AM

Change 350758 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/350758

gerritbot added a comment.Jun 26 2018, 10:57 PM

Change 442220 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] [WIP] Convert to extension.json

https://gerrit.wikimedia.org/r/442220

gerritbot added a project: Patch-For-Review.Jun 26 2018, 10:57 PM
gerritbot added a comment.Jul 27 2018, 12:03 AM

Change 442220 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] [BREAKING CHANGE] Convert to extension.json

https://gerrit.wikimedia.org/r/442220

Jdforrester-WMF closed this task as Resolved.Jul 27 2018, 12:07 AM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF closed subtask T118080: Rewrite $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet settings as a map from transcode to boolean for enabled status as Resolved.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 27 2018, 1:00 AM
gerritbot added a comment.Jul 30 2018, 6:15 PM

Change 449260 had a related patch set uploaded (by Brion VIBBER; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@wmf/1.32.0-wmf.14] [BREAKING CHANGE] Convert to extension.json

https://gerrit.wikimedia.org/r/449260

gerritbot added a project: Patch-For-Review.Jul 30 2018, 6:15 PM
gerritbot added a comment.Jul 30 2018, 11:54 PM

Change 449260 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.32.0-wmf.14] [BREAKING CHANGE] Convert to extension.json

https://gerrit.wikimedia.org/r/449260

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 31 2018, 12:01 AM
Stashbot subscribed.Jul 31 2018, 12:05 AM

Mentioned in SAL (#wikimedia-operations) [2018-07-31T00:05:31Z] <thcipriani@deploy1001> Started scap: SWAT: [[gerrit:449260|Convert to extension.json]] T87981 [[gerrit:449372|Use maps for wgEnabledTranscodeSet]] T118080 [[gerrit:449373|Adjust VP9 encoding for speed, quality]] [[gerrit:449374|More conservative max bitrate for VP9 video transcodes]]

Stashbot mentioned this in T118080: Rewrite $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet settings as a map from transcode to boolean for enabled status.Jul 31 2018, 12:05 AM
Stashbot added a comment.Jul 31 2018, 12:39 AM

Mentioned in SAL (#wikimedia-operations) [2018-07-31T00:39:16Z] <thcipriani@deploy1001> Finished scap: SWAT: [[gerrit:449260|Convert to extension.json]] T87981 [[gerrit:449372|Use maps for wgEnabledTranscodeSet]] T118080 [[gerrit:449373|Adjust VP9 encoding for speed, quality]] [[gerrit:449374|More conservative max bitrate for VP9 video transcodes]] (duration: 33m 44s)

gerritbot added a comment.Aug 7 2018, 5:11 PM

Change 451036 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@REL1_31] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/451036

gerritbot added a comment.Aug 7 2018, 5:11 PM

Change 451041 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@REL1_31] [BREAKING CHANGE] Convert to extension.json

https://gerrit.wikimedia.org/r/451041

gerritbot added a comment.Aug 7 2018, 9:42 PM

Change 451036 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@REL1_31] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/451036

gerritbot added a comment.Aug 18 2018, 1:04 AM

Change 451041 merged by Umherirrender:
[mediawiki/extensions/TimedMediaHandler@REL1_31] [BREAKING CHANGE] Convert to extension.json

https://gerrit.wikimedia.org/r/451041

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits