Page MenuHomePhabricator
Create Task
Maniphest T88027

Apply Schema:Edit instrumentation to WikiEditor
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

https://meta.wikimedia.org/wiki/Schema:Edit

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiEditormaster+277 -1Schema:Edit instrumentation
mediawiki/coremaster+19 -6Add a hook run after EditPage::attemptSave for WikiEditor
mediawiki/coremaster+50 -10Fix hook situation for Skin::doEditSectionLink
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jan 29 2015, 11:47 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor-Performance, WikiEditor, VisualEditor.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2015, 11:47 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Jan 30 2015, 1:20 AM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Jan 31 2015, 2:03 AM
Krenair mentioned this in T78461: Implement Schema:Edit in the Mobile Apps..Jan 31 2015, 7:22 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 3 2015, 5:54 PM
Krenair added subscribers: Catrope, ori, • TrevorParscal, Esanders.Feb 4 2015, 2:31 PM
• TrevorParscal set Security to None.Feb 4 2015, 7:00 PM
• TrevorParscal edited a custom field.
• TrevorParscal edited a custom field.Feb 4 2015, 7:11 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 4 2015, 8:09 PM
gerritbot added a project: Patch-For-Review.Feb 6 2015, 7:52 PM
gerritbot added a subscriber: gerritbot.

Change 189049 had a related patch set uploaded (by Alex Monk):
Add a hook run after EditPage::attemptSave for WikiEditor

https://gerrit.wikimedia.org/r/189049

Patch-For-Review

Jdforrester-WMF mentioned this in VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 9:53 PM
gerritbot added a comment.Feb 14 2015, 12:21 AM

Change 190607 had a related patch set uploaded (by Alex Monk):
Fix hook situation for Skin::doEditSectionLink

https://gerrit.wikimedia.org/r/190607

Patch-For-Review

gerritbot added a comment.Feb 18 2015, 12:32 AM

Change 191221 had a related patch set uploaded (by Alex Monk):
[WIP] Schema:Edit instrumentation

https://gerrit.wikimedia.org/r/191221

Patch-For-Review

Krenair added projects: Analytics, MediaWiki-Core-Team.EditedFeb 18 2015, 12:57 AM
Krenair added subscribers: Milimetric, Nuria.

TODO:

  • I should figure out what we can do about action.abort.type
  • Deal with the action.saveFailure.type schema issues ( Analytics )
  • Review my WikiEditor commit and its dependencies ( MediaWiki-Core-Team, #Editing )
gerritbot added a comment.Feb 19 2015, 4:09 PM

Change 190607 merged by jenkins-bot:
Fix hook situation for Skin::doEditSectionLink

https://gerrit.wikimedia.org/r/190607

Legoktm mentioned this in rMW56c1c43dc5d9: Fix hook situation for Skin::doEditSectionLink.Feb 19 2015, 4:09 PM
Legoktm moved this task from Backlog to Needs Review/Feedback on the MediaWiki-Core-Team board.Feb 19 2015, 4:11 PM
gerritbot added a comment.Feb 19 2015, 6:18 PM

Change 191658 had a related patch set uploaded (by Alex Monk):
Use new SkinEditSectionLinks hook instead of DoEditSectionLink

https://gerrit.wikimedia.org/r/191658

Patch-For-Review

gerritbot added a comment.Feb 26 2015, 4:52 PM

Change 189049 merged by jenkins-bot:
Add a hook run after EditPage::attemptSave for WikiEditor

https://gerrit.wikimedia.org/r/189049

Krenair mentioned this in rMWd69ffc8d6e70: Add a hook run after EditPage::attemptSave for WikiEditor.Feb 26 2015, 4:52 PM
Krenair added a comment.Mar 5 2015, 10:03 PM
In T88027#1045283, @gerritbot wrote:

Change 191221 had a related patch set uploaded (by Alex Monk):
[WIP] Schema:Edit instrumentation

https://gerrit.wikimedia.org/r/191221

Patch-For-Review

Okay, this is now no longer WIP and ready for review. It should do everything that Analytics needs to get useful data.

Liuxinyu970226 added a subscriber: Liuxinyu970226.Mar 9 2015, 7:04 AM
gerritbot added a comment.Mar 10 2015, 1:59 PM

Change 191221 merged by jenkins-bot:
Schema:Edit instrumentation

https://gerrit.wikimedia.org/r/191221

Catrope mentioned this in rEWED74da530f2d8c: Schema:Edit instrumentation.Mar 10 2015, 2:00 PM
Jdforrester-WMF closed this task as Resolved.Mar 10 2015, 3:47 PM
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Mar 10 2015, 4:15 PM
Jdforrester-WMF added a project: WMF-deploy-2015-03-11_(1.25wmf21).Mar 10 2015, 7:14 PM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Mar 10 2015, 11:38 PM
Krenair mentioned this in rMEXT08823407e73a: Updated mediawiki/extensions Project: mediawiki/extensions/WikiEditor….Mar 11 2015, 6:28 AM
Anomie moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Mar 12 2015, 7:44 PM
bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.Mar 16 2015, 9:10 PM
Krinkle moved this task from Backlog to Done on the VisualEditor-Performance board.Mar 19 2015, 10:34 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 20 2015, 11:32 PM
TheDJ added a subscriber: TheDJ.Mar 21 2015, 9:26 AM

These changes are somehow causing: T93384

TheDJ mentioned this in T93384: WikiEditor toolbar is loaded twice when editing.Mar 21 2015, 9:27 AM
Ricordisamoa added a subscriber: Ricordisamoa.Mar 26 2015, 6:21 AM
GOIII moved this task from Backlog to Closed on the WikiEditor board.Apr 3 2016, 9:54 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL