Page MenuHomePhabricator
Create Task
Maniphest T88090

Most button types do not support keyboard triggering
Closed, ResolvedPublic
Actions

Description

Half the widgets can currently not be selected using the keyboard, since they do not seem to have a key handler installed. only ButtonWidget seems to have this ?

At least ToggleButtonWidget, ButtonSelectWidget, ButtonGroupWidget, DropdownWidget etc...

Details

SubjectRepoBranchLines +/-
Refactor clickability of buttonsoojs/uimaster+126 -106
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Jan 30 2015, 8:05 AM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: OOUI, Accessibility.
TheDJ subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:05 AM
Jdforrester-WMF triaged this task as High priority.Feb 2 2015, 3:33 AM
matmarex added a parent task: T87693: PopupButtonWidget cannot be activated by keyboard.Feb 7 2015, 3:06 PM
matmarex claimed this task.Feb 7 2015, 3:16 PM
matmarex merged a task: T87693: PopupButtonWidget cannot be activated by keyboard.
matmarex removed a parent task: T87693: PopupButtonWidget cannot be activated by keyboard.
gerritbot added a project: Patch-For-Review.Feb 7 2015, 6:31 PM
gerritbot subscribed.

Change 189236 had a related patch set uploaded (by Bartosz Dziewoński):
Refactor clickability of buttons

https://gerrit.wikimedia.org/r/189236

Patch-For-Review

matmarex mentioned this in T88906: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible.Feb 7 2015, 7:59 PM
matmarex added a subtask: T88906: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible.Feb 7 2015, 8:00 PM
matmarex moved this task from Backlog to Doing on the OOUI board.Feb 7 2015, 8:13 PM
matmarex removed a subtask: T88906: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible.Feb 9 2015, 3:09 PM
matmarex added a parent task: T88906: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible.
gerritbot added a comment.Feb 9 2015, 11:26 PM

Change 189236 merged by jenkins-bot:
Refactor clickability of buttons

https://gerrit.wikimedia.org/r/189236

matmarex closed this task as Resolved.Feb 10 2015, 2:03 AM
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex removed a subscriber: gerritbot.
matmarex mentioned this in rGOJU9e9683731eb8: Refactor clickability of buttons.Mar 3 2015, 7:50 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL