Page MenuHomePhabricator
Create Task
Maniphest T88091

SelectWidget group of OptionWidget is not presenting its state
Closed, ResolvedPublic
Actions

Description

There are two problems here. The OptionWidget has the option role, but they are not wrapped by an grouping element (SelectWidget) with a proper role of listbox.

Secondary, the option items don't represent their state

Details

SubjectRepoBranchLines +/-
SelectWidget: 'listbox' wrapper role, 'aria-selected' state on contentsoojs/uimaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Jan 30 2015, 8:07 AM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: OOUI, Accessibility.
TheDJ subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:07 AM
gerritbot added a project: Patch-For-Review.Jan 30 2015, 8:09 AM
gerritbot subscribed.

Change 187655 had a related patch set uploaded (by TheDJ):
SelectWidget: listbox wrapper role, state on contents

https://gerrit.wikimedia.org/r/187655

Patch-For-Review

Ricordisamoa renamed this task from SelectWidget group of OptionWidget is not presenting it's state to SelectWidget group of OptionWidget is not presenting its state.Jan 30 2015, 12:07 PM
Ricordisamoa set Security to None.
Jdforrester-WMF triaged this task as High priority.Feb 2 2015, 3:33 AM
gerritbot added a comment.Feb 5 2015, 4:58 PM

Change 187655 merged by jenkins-bot:
SelectWidget: 'listbox' wrapper role, 'aria-selected' state on contents

https://gerrit.wikimedia.org/r/187655

Jdforrester-WMF closed this task as Resolved.Feb 5 2015, 5:57 PM
Jdforrester-WMF assigned this task to TheDJ.
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
Jdforrester-WMF edited projects, added WMF-deploy-2015-02-11_(1.25wmf17); removed Patch-For-Review.
matmarex mentioned this in rGOJU7742bd7484f7: SelectWidget: 'listbox' wrapper role, 'aria-selected' state on contents.Mar 3 2015, 7:50 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL