Page MenuHomePhabricator
Create Task
Maniphest T88093

Warnings when running `mwscript eval.php` on deployment-prep
Closed, ResolvedPublic
Actions

Description

krenair@deployment-bastion:~$ mwscript eval.php --wiki=commonswiki
PHP Notice:  Undefined variable: wmgMFWikiDataEndpoint in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 26

Notice: Undefined variable: wmgMFWikiDataEndpoint in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 26
PHP Notice:  Undefined variable: wmgWikiBasePropertyConfig in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 27

Notice: Undefined variable: wmgWikiBasePropertyConfig in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 27
PHP Notice:  Undefined variable: wmgMFInfoboxConfig in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 28

Notice: Undefined variable: wmgMFInfoboxConfig in /mnt/srv/mediawiki-staging/wmf-config/mobile-labs.php on line 28
>

Also seen in P244

Details

SubjectRepoBranchLines +/-
Mobile: Fix JS-Exception for non-english beta projectsoperations/mediawiki-configmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.Jan 30 2015, 8:53 AM
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added projects: Release-Engineering-Team, Beta-Cluster-Infrastructure, Mobile.
Krenair subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:53 AM
Krenair renamed this task from Warnings when running mwscript on deployment-prep to Warnings when running `mwscript eval.php` on deployment-prep.Jan 30 2015, 9:27 AM
Krenair set Security to None.
hashar added subscribers: Jdlrobson, hashar.Jan 30 2015, 9:11 PM

That is caused by https://gerrit.wikimedia.org/r/#/c/186319/ which adds the variables in mobile-labs.php :

+$wgMFWikiDataEndpoint = $wmgMFWikiDataEndpoint;
+$wgWikiBasePropertyConfig = $wmgWikiBasePropertyConfig;
+$wgMFInfoboxConfig = $wmgMFInfoboxConfig;

Apparently loaded before InitialiseSettings-labs.php had a chance to be loaded/applied.

Catrope added subscribers: Catrope, bd808.Jan 30 2015, 10:52 PM
In T88093#1005071, @hashar wrote:

Apparently loaded before InitialiseSettings-labs.php had a chance to be loaded/applied.

No, per @bd808's Gerrit comments from a week ago, it's because those settings don't have a default value set.

Krenair added subscribers: ori, Dzahn, Joe.Jan 31 2015, 6:54 AM
hashar merged a task: T88283: PHP notices on eval.php on deployment-bastion.Feb 2 2015, 3:27 PM
hashar added subscribers: Reedy, yuvipanda.
hashar merged a task: T88421: Undefined variables in wmf-config.Feb 3 2015, 5:49 PM
hashar added subscribers: hoo, 01tonythomas.
Krenair assigned this task to Jdlrobson.Feb 5 2015, 1:24 AM
Florian merged a task: T89095: Beta Cluster (except enwiki): Exception "TypeError: config is null".Feb 10 2015, 10:04 AM
Florian added subscribers: gerritbot, Florian.
gerritbot added a project: Patch-For-Review.Feb 10 2015, 10:05 AM

Change 189693 had a related patch set uploaded (by Florianschmidtwelzow):
Mobile: Fix JS-Exception for non-english beta projects

https://gerrit.wikimedia.org/r/189693

Patch-For-Review

Florian claimed this task.Feb 10 2015, 10:06 AM
Florian added a project: Web-Team-Backlog.Feb 10 2015, 10:08 AM
Florian moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
gerritbot added a comment.Feb 10 2015, 10:56 AM

Change 189693 merged by jenkins-bot:
Mobile: Fix JS-Exception for non-english beta projects

https://gerrit.wikimedia.org/r/189693

hoo closed this task as Resolved.Feb 10 2015, 10:59 AM

Patch approved and deployed.

greg moved this task from INBOX to Done on the Release-Engineering-Team board.Feb 24 2015, 11:35 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
Florian mentioned this in rOMWC973ecb80389c: Mobile: Fix JS-Exception for non-english beta projects.Mar 3 2015, 9:01 PM
greg moved this task from To Triage to Done on the Beta-Cluster-Infrastructure board.Mar 5 2015, 4:45 PM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:55 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL