Maniphest T88117

Update HTML title with displaytitle on live preview
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Jan 30 2015, 3:34 PM

Project Tags

Referenced Files

None

Subscribers

Description

The HTML title is not updated on live preview.

Steps to reproduce:

Enable live preview in preferences
Open https://test.wikipedia.org/w/index.php?title=Sandbox&action=edit
Enter {{DISPLAYTITLE:sandbox}}
Click on "Show preview"

Current result: The HTML title still contains:

Editing "Sandbox" - Test Wikipedia

Expected result: The HTML title should contain:

Editing "sandbox" - Test Wikipedia

With disabled live preview the HTML title is updated correctly with the displaytitle.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update HTML title with displaytitle on live preview	mediawiki/core	master	+17 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T41272 Bugs in "Live preview" feature (tracking)
		Resolved		Fomafix	T88117 Update HTML title with displaytitle on live preview

Event Timeline

Fomafix created this task.Jan 30 2015, 3:34 PM

Fomafix raised the priority of this task from to Low.

Fomafix updated the task description. (Show Details)

Fomafix added a project: Contributors-Team.

Fomafix subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 3:34 PM

Fomafix added a subtask: T41272: Bugs in "Live preview" feature (tracking).Jan 30 2015, 3:35 PM

Fomafix removed a subtask: T41272: Bugs in "Live preview" feature (tracking).

Fomafix added a parent task: T41272: Bugs in "Live preview" feature (tracking).

Fomafix claimed this task.Jan 30 2015, 6:09 PM

Change 187710 had a related patch set uploaded (by Gerrit Patch Uploader):
Update HTML title with displaytitle on live preview

https://gerrit.wikimedia.org/r/187710

Patch-For-Review

Krenair added a project: MediaWiki-Page-editing.Jan 31 2015, 7:19 AM

Krenair subscribed.

Fomafix added a comment.Feb 1 2015, 11:35 AM

This comment was removed by Fomafix.

Krinkle subscribed.Feb 12 2015, 11:32 PM

TheDJ subscribed.Feb 19 2015, 9:44 AM

TheDJ mentioned this in T85784: LivePreview should not replace title message with displaytitle value in firstHeading.Mar 17 2015, 9:13 AM

Change 187710 merged by jenkins-bot:
Update HTML title with displaytitle on live preview

https://gerrit.wikimedia.org/r/187710

TheDJ mentioned this in rMW3eafa8dd37a4: Update HTML title with displaytitle on live preview.Mar 24 2015, 11:20 PM

Krenair mentioned this in T51667: <title> of editing page doesn't respect DISPLAYTITLE.Mar 24 2015, 11:22 PM

So we now do this on preview, but it's a bit strange because we don't do it on initial page load. See T51667 (and please feel free to claim that task if you plan to work on it!)

Krenair closed this task as Resolved.Mar 25 2015, 12:09 AM

Krenair removed a project: Patch-For-Review.

Krenair set Security to None.