Page MenuHomePhabricator

Unnecessary line breaks in Phabricator comments generated from emails
Closed, DeclinedPublic

Description

I tried the "reply by email" feature of Phabricator; it works pretty well, the only problem is that lines are broken up to be less than 80 (I guess? did not count) characters. This looks ugly and also breaks some formatting.

The email sent by Phabricator (and thus my response) does not have those linebreaks, so this must happen either somewhere in the WMF mailing architecture or in the Phabricator email-to-comment conversion.

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: Phabricator.
Tgr subscribed.

Can you paste your original source response and link to the comment it transformed into?

Can you paste your original source response and link to the comment it transformed into?

T87056#1004742 (edited, you'll have to look at the history)

MIME-Version: 1.0
Received: by 10.140.175.215 with HTTP; Fri, 30 Jan 2015 11:13:00 -0800 (PST)
In-Reply-To: <fcd52e937bd71fccb1e35eb1aff6ac51@localhost.localdomain>
References: <maniphest-task-PHID-TASK-gxmwajamag7sqz6ddiif@phabricator.wikimedia.org>
	<fcd52e937bd71fccb1e35eb1aff6ac51@localhost.localdomain>
Date: Fri, 30 Jan 2015 11:13:00 -0800
Delivered-To: gtisza@wikimedia.org
Message-ID: <CAEVcXn13GPWHWGQg9REpLfR8CSwkekYJyg+CKU6zGVqijZhY8Q@mail.gmail.com>
Subject: Re: [Maniphest] T87056: No way to get to file page of audio file from
 a gallery
From: Gergo Tisza <gtisza@wikimedia.org>
To: T87056+public+be9df4727351bee4@phabricator.wikimedia.org
Content-Type: multipart/alternative; boundary=001a11c03e269ab7d6050de3647d

--001a11c03e269ab7d6050de3647d
Content-Type: text/plain; charset=UTF-8

> I've found the logic and it's actually trying to cram everything it can
in the available space, going left to right. Now I'll check if the
"available space" calculation is correct.

The space after the play button is unreasonably large, so it should be easy
to chip away there if not everything fits. (I wonder if maybe a progress
indicator used to be there / is there for some clients? It would be the
logical place but I don't see anything like that,

On Fri, Jan 30, 2015 at 11:03 AM, Gilles <no-reply@phabricator.wikimedia.org
> wrote:

> Gilles added a comment.
>
> I've found the logic and it's actually trying to cram everything it can in
> the available space, going left to right. Now I'll check if the "available
> space" calculation is correct.
>
> *TASK DETAIL*
> https://phabricator.wikimedia.org/T87056
>
> *REPLY HANDLER ACTIONS*
> Reply to comment or attach files, or !close, !claim, !unsubscribe or
> !assign <username>.
>
> *EMAIL PREFERENCES*
> https://phabricator.wikimedia.org/settings/panel/emailpreferences/
>
> *To: *Gilles
> *Cc: *Unicodesnowman, Josve05a, Aklapper, Tgr, Fabrice_Florin, Gilles
>

--001a11c03e269ab7d6050de3647d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">&gt;=C2=A0I&#39;ve found the logic and it&#39;s actually t=
rying to cram everything it can in the available space, going left to right=
. Now I&#39;ll check if the &quot;available space&quot; calculation is corr=
ect.<div><br></div><div>The space after the play button is unreasonably lar=
ge, so it should be easy to chip away there if not everything fits. (I wond=
er if maybe a progress indicator used to be there / is there for some clien=
ts? It would be the logical place but I don&#39;t see anything like that,</=
div><div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Fri, =
Jan 30, 2015 at 11:03 AM, Gilles <span dir=3D"ltr">&lt;<a href=3D"mailto:no=
-reply@phabricator.wikimedia.org" target=3D"_blank">no-reply@phabricator.wi=
kimedia.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(2=
04,204,204);border-left-style:solid;padding-left:1ex"><div>Gilles added a c=
omment.</div><br><p>I&#39;ve found the logic and it&#39;s actually trying t=
o cram everything it can in the available space, going left to right. Now I=
&#39;ll check if the &quot;available space&quot; calculation is correct.</p=
><span class=3D""><br><div><strong>TASK DETAIL</strong><div><a href=3D"http=
s://phabricator.wikimedia.org/T87056" rel=3D"noreferrer" target=3D"_blank">=
https://phabricator.wikimedia.org/T87056</a></div></div><br><div><strong>RE=
PLY HANDLER ACTIONS</strong><div><div>Reply to comment or attach files, or =
!close, !claim, !unsubscribe or !assign &lt;username&gt;.</div></div></div>=
<br><div><strong>EMAIL PREFERENCES</strong><div><a href=3D"https://phabrica=
tor.wikimedia.org/settings/panel/emailpreferences/" rel=3D"noreferrer" targ=
et=3D"_blank">https://phabricator.wikimedia.org/settings/panel/emailprefere=
nces/</a></div></div><br></span><div><strong>To: </strong>Gilles<span class=
=3D""><br><strong>Cc: </strong>Unicodesnowman, Josve05a, Aklapper, Tgr, Fab=
rice_Florin, Gilles<br></span></div>


</blockquote></div><br></div></div></div>

--001a11c03e269ab7d6050de3647d--

I guess what happens is that Gmail line wraps the text version (which is an RFC 2822 recommendation), and Phabricator uses that instead of the HTML one. In which case there is probably no easy way to fix this.

Yes it seems that is the case :) Feel free to upstream this if you desire but I'm going to say there is nothing to address from phab upstream's perspective.

declined?

Aklapper triaged this task as Lowest priority.Feb 2 2015, 6:38 PM
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.
Aklapper set Security to None.

and Phabricator uses that instead of the HTML one. In which case there is probably no easy way to fix this.

Configure gmail to send an HTML-only message? Or switch to Thunderbird, where it's extremely easy to choose, both by default and for the individual message/recipient. :)

Qgil claimed this task.
Qgil subscribed.

Yes it seems that is the case :) Feel free to upstream this if you desire but I'm going to say there is nothing to address from phab upstream's perspective.

declined?