MW-Vagrant's docroot should be available from the host machine
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jan 30 2015, 8:21 PM

Description

Since the multiwiki features were added, debugging is broken in Vagrant. If you try to use it, you get something like this:

vagrant_xdebug_broken.png (218×607 px, 18 KB)

This is in PHPStorm, maybe other IDEs are more clever, I don't know. But at the very least it is impossible to debug multiwiki issues since the PHP files under /var/www are not accessible from the host machine. Vagrant should put those files under /vagrant/docroot or something and symlink /var/www to that (or copy if symlinking is problematic although the ability to access and alter those files from an IDE would be nice).

Details

Subject	Repo	Branch	Lines +/-
Fix ordering for /vagrant/srv/composer	mediawiki/vagrant	master	+1 -0
Make composer accessible to the debugger	mediawiki/vagrant	master	+5 -0
Make sure all PHP files are available from the host machine	mediawiki/vagrant	master	+9 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Tgr	T88149 MW-Vagrant's docroot should be available from the host machine
		Resolved		Tgr	T88145 Use ::mediawiki::apache::docroot hiera variable consistently to specify docroot in MW-Vagrant

Event Timeline

Tgr created this task.Jan 30 2015, 8:21 PM

Tgr raised the priority of this task from to Needs Triage.

Tgr updated the task description. (Show Details)

Tgr added a project: MediaWiki-Vagrant.

Tgr subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:21 PM

Tgr added a subtask: T88145: Use ::mediawiki::apache::docroot hiera variable consistently to specify docroot in MW-Vagrant.Jan 31 2015, 2:11 AM

Placing the files under /vagrant runs into permission problems due to NFS root squashing. I guess it will have to be done via copying.

Change 187874 had a related patch set uploaded (by Gergő Tisza):
Make sure all PHP files are available from the host machine

https://gerrit.wikimedia.org/r/187874

Patch-For-Review

Doesn't work very reliably, some files are not picked up on the first provisioning run. Probably a timing issue.

Setting up the directories for remote debugging is not very user-friendly in PHPStorm. This snippet can be added to .idea/workspace.xml to fix it:

<component name="PhpServers">
  <option name="servers">
    <server host="<host>" name="<host>" port="<port>" use_path_mappings="true">
      <path_mappings>
        <path_mapping local_path="$PROJECT_DIR$/docroot" remote_path="/var/www" />
        <path_mapping local_path="$PROJECT_DIR$" remote_path="/vagrant" />
      </path_mappings>
    </server>
  </option>
</component>

I don't think there is a good way to do that via the git repo or vagrant, though.

Tgr mentioned this in T85976: Remove .idea (PHPStorm project settings container) from Vagrant repo.Feb 2 2015, 10:00 PM

Tgr merged a task: T72907: Access MultiVersion files from host.Feb 10 2015, 2:36 AM

Tgr added subscribers: ori, • bd808, Rillke and 3 others.

In T88149#1005961, @Tgr wrote:

I don't think there is a good way to do that via the git repo or vagrant, though.

Reported that upstream as https://youtrack.jetbrains.com/issue/WI-26425

Tgr closed subtask T88145: Use ::mediawiki::apache::docroot hiera variable consistently to specify docroot in MW-Vagrant as Resolved.Apr 3 2015, 6:21 AM

Reedy removed a subscriber: • wikibugs-l-list.Nov 29 2015, 2:05 PM

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 29 2015, 2:05 PM

Ardnet5 subscribed.Jun 4 2016, 4:13 AM

Change 187874 merged by jenkins-bot:
Make sure all PHP files are available from the host machine

https://gerrit.wikimedia.org/r/187874

Available as /vagrant/srv/docroot.

Tgr closed this task as Resolved.Dec 13 2016, 8:01 AM

Tgr claimed this task.

• bd808 mentioned this in T154967: Problems with symlinks in vagrant on windows host.Jan 10 2017, 5:38 AM

Change 973884 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/vagrant@master] Make composer accessible to the debugger

https://gerrit.wikimedia.org/r/973884

Change 973884 merged by jenkins-bot:

[mediawiki/vagrant@master] Make composer accessible to the debugger

https://gerrit.wikimedia.org/r/973884

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 12:30 AM

Change 984301 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/vagrant@master] Fix ordering for /vagrant/srv/composer

https://gerrit.wikimedia.org/r/984301

gerritbot added a project: Patch-For-Review.Dec 20 2023, 2:32 AM

Change 984301 merged by jenkins-bot: