Page MenuHomePhabricator
Create Task
Maniphest T88194

AutoloadGenerator.php doesn't update extension.json and skin.json
Closed, ResolvedPublic
Actions

Description

Echo, Flow, and a few other extensions use core's includes/utils/AutoloadGenerator.php to generate an autoload.php file that appends to $wgAutoloadClasses. As we convert to extension registration, this should be adapted to, e.g. load extension.json file, add the class map to its "AutoloadClasses" key, and write out the new extension.json.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+91 -62Also support skin.json for updating JSON AutoloadClasses
mediawiki/coreREL1_25+65 -32AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json
mediawiki/coremaster+65 -32AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Spage created this task.Jan 31 2015, 12:50 AM
• Spage raised the priority of this task from to Needs Triage.
• Spage updated the task description. (Show Details)
• Spage added a project: MediaWiki-Configuration.
• Spage added a subscriber: • Spage.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2015, 12:50 AM
Aklapper triaged this task as Medium priority.Feb 2 2015, 6:29 PM
Legoktm added a project: good first task.May 3 2015, 5:32 PM
Legoktm set Security to None.
• Mattflaschen-WMF added a parent task: T87910: Convert Echo to use extension registration.May 16 2015, 12:52 AM
• Mattflaschen-WMF added a parent task: T87916: Convert Flow to use extension registration.
Paladox added a subscriber: Legoktm.May 16 2015, 10:38 AM
Ricordisamoa added a subscriber: Ricordisamoa.May 17 2015, 12:58 AM
Liuxinyu970226 added a subscriber: Liuxinyu970226.May 18 2015, 3:34 AM
Galorefitz added a subscriber: Galorefitz.May 19 2015, 7:06 PM

Hi! I am new here and want to work on this task. A doubt: Is the script supposed to do something other than what it is currently doing, if extension.json does not exist?

Legoktm added a comment.May 19 2015, 9:24 PM
In T88194#1297176, @Galorefitz wrote:

Hi! I am new here and want to work on this task. A doubt: Is the script supposed to do something other than what it is currently doing, if extension.json does not exist?

Hi! Sorry I missed you on IRC. So I was imagining that AutoloadGenerator::generateAutoload() would check to see if a extension.json exists, and update it if that was the case. Otherwise it'll just update autoload.php if that file exists..

gerritbot added a subscriber: gerritbot.May 24 2015, 10:10 PM

Change 213468 had a related patch set uploaded (by Galorefitz):
AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json

https://gerrit.wikimedia.org/r/213468

gerritbot added a project: Patch-For-Review.May 24 2015, 10:10 PM
• Mattflaschen-WMF assigned this task to Galorefitz.May 27 2015, 9:50 AM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.
gerritbot added a comment.Jun 11 2015, 3:23 AM

Change 213468 merged by jenkins-bot:
AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json

https://gerrit.wikimedia.org/r/213468

Galorefitz mentioned this in rMWcbcbbf2bf145: AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json.Jun 11 2015, 3:23 AM
Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-06-16_(1.26wmf10).Jun 11 2015, 4:01 AM
Forrestbot added a subscriber: Forrestbot.
Galorefitz closed this task as Resolved.Jun 11 2015, 7:12 AM
Galorefitz removed a project: Patch-For-Review.
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jun 11 2015, 7:15 AM
gerritbot added a comment.Jun 11 2015, 6:54 PM

Change 217590 had a related patch set uploaded (by Paladox):
AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json

https://gerrit.wikimedia.org/r/217590

gerritbot added a project: Patch-For-Review.Jun 11 2015, 6:54 PM
gerritbot added a comment.Jun 12 2015, 3:31 AM

Change 217768 had a related patch set uploaded (by Mattflaschen):
Also support skin.json for updating JSON AutoloadClasses

https://gerrit.wikimedia.org/r/217768

gerritbot added a comment.Jun 20 2015, 10:31 PM

Change 217590 abandoned by Legoktm:
AutoloadGenerator.php: Update 'AutoloadClasses' in extension.json

Reason:
Doesn't need to be backported

https://gerrit.wikimedia.org/r/217590

• Mattflaschen-WMF reopened this task as Open.Jun 22 2015, 6:56 AM

skin.json is not merged.

Ricordisamoa renamed this task from AutoloadGenerator.php doesn't update extension.json to AutoloadGenerator.php doesn't update extension.json and skin.json.Jun 22 2015, 8:23 AM
gerritbot added a comment.Jun 25 2015, 7:18 AM

Change 217768 merged by jenkins-bot:
Also support skin.json for updating JSON AutoloadClasses

https://gerrit.wikimedia.org/r/217768

• Mattflaschen-WMF mentioned this in rMW2cb0f735e2df: Also support skin.json for updating JSON AutoloadClasses.Jun 25 2015, 7:18 AM
Legoktm closed this task as Resolved.Jun 25 2015, 7:20 AM
Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 25 2015, 8:00 AM
Ricordisamoa removed a project: Patch-For-Review.Jun 25 2015, 9:00 AM
Legoktm removed a subscriber: Forrestbot.Jun 29 2015, 5:50 PM
J5lx added a subscriber: J5lx.Sep 3 2015, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL