Page MenuHomePhabricator

wrong notice about pending template or file changes for flagged revs
Closed, ResolvedPublic

Description

Some file pages on dewiki shows a notice about Template/file changes are pending review, but clicking the provide link does not show the box for pending templates. It is not possible using the gui review to remove this notice (just by unreview all reviewed revision). Looking at the replicated database on dewiki the problem is that the fr_img_sha1 column for the latest revision is NULL. In FlaggedWikiPage::stableVersionIsSynced the NULL is compared against the current file timestamp and there NULL is lower than and the function returns true.

Use the following query to find some example pages

select fr_rev_id
  from flaggedrevs, page
 where fr_page_id = page_id
   and fr_rev_id = page_latest
   and page_namespace = 6
   and fr_img_sha1 is null
 limit 10;

Event Timeline

Umherirrender raised the priority of this task from to Medium.
Umherirrender updated the task description. (Show Details)
Umherirrender added subscribers: Umherirrender, aaron.

The issue should be already gone in the meantime