Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	PleaseStand
	Jan 31 2015, 11:00 PM

Description

wikihiero has the same problem as in T85007, though @Legoktm's comment on Patch Set 2 of https://gerrit.wikimedia.org/r/#/c/183906/ seems to suggest that the ResourceLoaderRegisterModules hook should be used instead of $wgExtensionFunctions for conditional registration of modules.

There was 1 error:

1) ResourcesTest::testUnsatisfiableDependencies
Undefined index: ext.visualEditor.mwcore

/home/ki/Projects/mediawiki/core/tests/phpunit/structure/ResourcesTest.php:94
/home/ki/Projects/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:141

--

There were 2 failures:

[...]

2) ResourcesTest::testMissingDependencies
The module 'ext.visualEditor.mwcore' required by 'ext.wikihiero.visualEditor' must exist
Failed asserting that an array contains 'ext.visualEditor.mwcore'.

/home/ki/Projects/mediawiki/core/tests/phpunit/structure/ResourcesTest.php:74
/home/ki/Projects/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:141

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hygiene: Move magic mobile VE module registration out of extension function	mediawiki/extensions/MobileFrontend	master	+8 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T88227 Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed
Open	None	T88229 wikihiero: VisualEditor JavaScript should only be added if VisualEditor is installed
Open	None	T88230 Disambiguator: Only register VisualEditor module if VisualEditor is installed
Declined	Jdforrester-WMF	T88231 Math: VisualEditor JavaScript should only be added if VisualEditor is installed
Invalid	Krenair	T88233 WikimediaEvents: VisualEditor JavaScript should only be added if VisualEditor is installed
Duplicate	None	T88331 Add VisualEditor to Jenkins dependencies for WikiHiero
Open	None	T162006 score/extension.json should list VE dependency or move to conditional

Event Timeline

PleaseStand created this task.Jan 31 2015, 11:00 PM

PleaseStand raised the priority of this task from to Needs Triage.

PleaseStand updated the task description. (Show Details)

PleaseStand added a project: WikiHiero.

PleaseStand added subscribers: PleaseStand, hashar, Florian, Legoktm.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2015, 11:00 PM

Apparently, Disambiguator, Math, and WikimediaEvents are also affected (in addition to wikihiero). This is already blocking merging of two changes:

PleaseStand renamed this task from wikihiero: VisualEditor JavaScript should only be added if VisualEditor is installed to Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed.Feb 1 2015, 1:47 AM

PleaseStand edited projects, added Tracking-Neverending, JavaScript; removed WikiHiero.

PleaseStand set Security to None.

PleaseStand mentioned this in T88229: wikihiero: VisualEditor JavaScript should only be added if VisualEditor is installed.

PleaseStand mentioned this in T88230: Disambiguator: Only register VisualEditor module if VisualEditor is installed.Feb 1 2015, 1:49 AM

PleaseStand mentioned this in T88231: Math: VisualEditor JavaScript should only be added if VisualEditor is installed.

PleaseStand mentioned this in T88233: WikimediaEvents: VisualEditor JavaScript should only be added if VisualEditor is installed.Feb 1 2015, 1:52 AM

Ricordisamoa subscribed.Feb 1 2015, 1:55 AM

Change 187945 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Move magic mobile VE module registration out of extension function

https://gerrit.wikimedia.org/r/187945

Patch-For-Review

Change 187945 merged by jenkins-bot:
Hygiene: Move magic mobile VE module registration out of extension function

https://gerrit.wikimedia.org/r/187945

Florian mentioned this in rEMFR8dc5006db9a1: Hygiene: Move magic mobile VE module registration out of extension function.Feb 1 2015, 3:53 AM

Aklapper triaged this task as High priority.Feb 2 2015, 6:24 PM

hashar mentioned this in T88331: Add VisualEditor to Jenkins dependencies for WikiHiero.Feb 3 2015, 11:01 AM

hashar added a subtask: T88331: Add VisualEditor to Jenkins dependencies for WikiHiero.

I'm not sure whether it makes sense to make the registration of these modules conditional. Except for the failing test, everything should be working fine as the module isn't added. I don't think it's unreasonable for unit tests to require additional dependencies even if the extension functions fine without them.

My comment was mainly that if you have to use conditional registration for whatever reason, you should use the ResourceLoaderRegisterModules hook instead of a $wgExtensionFunction.

Florian mentioned this in rMEXTacfa35801753: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:25 AM

Liuxinyu970226 subscribed.May 12 2015, 3:12 PM

Nemo_bis added a project: MediaWiki-extensions-Other.Jul 19 2015, 9:48 AM

Krenair added projects: VisualEditor, VisualEditor-MediaWiki.Aug 18 2015, 4:10 AM

Krenair subscribed.

Jdforrester-WMF lowered the priority of this task from High to Low.Aug 18 2015, 3:00 PM

Jdforrester-WMF subscribed.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Aug 18 2015, 3:51 PM

Krenair closed subtask T88233: WikimediaEvents: VisualEditor JavaScript should only be added if VisualEditor is installed as Invalid.Aug 21 2015, 7:11 PM

Liuxinyu970226 unsubscribed.Oct 5 2015, 7:33 AM

Jdforrester-WMF closed subtask T88231: Math: VisualEditor JavaScript should only be added if VisualEditor is installed as Declined.Dec 1 2015, 8:20 PM

matej_suchanek removed a project: Patch-For-Review.Feb 20 2016, 1:32 PM