Page MenuHomePhabricator

Disambiguator: Only register VisualEditor module if VisualEditor is installed
Open, Needs TriagePublic

Description

See T88227.

$wgResourceModules['ext.disambiguator.visualEditor'] = array(
	'localBasePath' => __DIR__,
	'remoteExtPath' => 'Disambiguator',
	'scripts' => array( 'visualEditorIntegration.js' ),
	'messages' => array( 'visualeditor-dialog-meta-settings-disambiguation-label' ),
	'dependencies' => array( 'ext.visualEditor.mwmeta', 'ext.visualEditor.mediawiki' ),
	'targets' => array( 'desktop', 'mobile' )
);
22:00:57 There was 1 error:
22:00:57 
22:00:57 1) ResourcesTest::testUnsatisfiableDependencies
22:00:57 Undefined index: ext.visualEditor.mediawiki
22:00:57 
22:00:57 /srv/ssd/jenkins-slave/workspace/mwext-Disambiguator-testextension-zend/src/tests/phpunit/structure/ResourcesTest.php:94
22:00:57 /srv/ssd/jenkins-slave/workspace/mwext-Disambiguator-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:133
22:00:57 
22:00:57 --

Event Timeline

PleaseStand raised the priority of this task from to Needs Triage.
PleaseStand updated the task description. (Show Details)
PleaseStand added subscribers: Aklapper, Legoktm, Florian and 2 others.
hashar removed a subscriber: hashar.Feb 1 2015, 11:37 AM
hashar added a subscriber: hashar.Feb 6 2015, 8:26 PM

The MobileFrontend extension has an example fix using the ResourceLoaderRegisterModules hook instead of an extension function: https://gerrit.wikimedia.org/r/187945

Krinkle renamed this task from Disambiguator: VisualEditor JavaScript should only be added if VisualEditor is installed to Disambiguator: Only register VisualEditor module if VisualEditor is installed.Feb 10 2015, 10:38 PM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.