Page MenuHomePhabricator
Create Task
Maniphest T88295

Overlays not designed to be run from head
Closed, ResolvedPublic
Actions

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads?mobileaction=alpha#/upload-tutorial/foo

TypeError: Cannot read property 'scrollTop' of null TypeError: Cannot read property 'scrollTop' of null

Overlay manager should ensure the body has loaded before trying to insert one in the page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show Overlays only after the DOM is readymediawiki/extensions/MobileFrontendmaster+10 -6
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 2 2015, 5:04 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog-Archived.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2015, 5:04 PM
Florian subscribed.Feb 2 2015, 5:36 PM
• KLans_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Feb 2 2015, 6:14 PM
Maryana moved this task from 2015-16 Q4 to Triaged but Future on the Web-Team-Backlog-Archived board.Feb 12 2015, 1:41 AM
Jdlrobson moved this task from Triaged but Future to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Feb 24 2015, 8:36 PM

Note this is not hygiene - this is a bug.

• KLans_WMF triaged this task as Medium priority.Mar 13 2015, 8:16 PM
• KLans_WMF set Security to None.
• bmansurov claimed this task.Mar 19 2015, 10:55 PM
gerritbot subscribed.Mar 19 2015, 10:56 PM

Change 198132 had a related patch set uploaded (by Bmansurov):
Show Overlays only after the DOM is ready

https://gerrit.wikimedia.org/r/198132

gerritbot added a project: Patch-For-Review.Mar 19 2015, 10:56 PM
• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog-Archived board.Mar 19 2015, 10:56 PM
gerritbot added a comment.Mar 20 2015, 8:15 PM

Change 198132 merged by jenkins-bot:
Show Overlays only after the DOM is ready

https://gerrit.wikimedia.org/r/198132

• bmansurov closed this task as Resolved.Mar 20 2015, 9:09 PM
• bmansurov mentioned this in rEMFRb63c1fbf58c1: Show Overlays only after the DOM is ready.Mar 23 2015, 3:53 PM
Diffusion mentioned this in rMEXT342e5906036a: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 23 2015, 3:56 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits